[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-63) Refactor "offline" feature placement in the API

[Andrew Rubinger (JIRA)]

     [ https://issues.jboss.org/browse/SHRINKRES-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Rubinger updated SHRINKRES-63:
-------------------------------------

    Description: 
>From Karel: 

The location of offline() method in MavenStrategyStage unfortunately does not cover all possible use cases:
Imagine the following:
User loads a pom - now the first resolution happens, because an effective pom is created and this is later used to define the dependencies:
{code}final File[] longhand = Resolvers.use(MavenResolverSystem.class).configureFromPom("path/to/pom").resolve("G:A").offline()
            .withTransitivity().as(File.class);{code}
I don't think that delaying ".configureFromPom("path/to/pom").resolve("G:A")" call until MavenStrategyStage is reached in the right way to go, because that way we couldn't for instance cache already parsed POM file.

  was:
>From Karel: 

The location of offline() method in MavenStrategyStage unfortunately does not cover all possible use cases:
Imagine the following:
User loads a pom - now the first resolution happens, because an effective pom is created and this is later used to define the dependencies:
final File[] longhand = Resolvers.use(MavenResolverSystem.class).configureFromPom("path/to/pom").resolve("G:A").offline()
            .withTransitivity().as(File.class);
I don't think that delaying ".configureFromPom("path/to/pom").resolve("G:A")" call until MavenStrategyStage is reached in the right way to go, because that way we couldn't for instance cache already parsed POM file.


    
> Refactor "offline" feature placement in the API
> -----------------------------------------------
>
>                 Key: SHRINKRES-63
>                 URL: https://issues.jboss.org/browse/SHRINKRES-63
>             Project: ShrinkWrap Resolvers
>          Issue Type: Feature Request
>    Affects Versions: 2.0.0-alpha-2
>            Reporter: Andrew Rubinger
>            Assignee: Karel Piwko
>
> From Karel: 
> The location of offline() method in MavenStrategyStage unfortunately does not cover all possible use cases:
> Imagine the following:
> User loads a pom - now the first resolution happens, because an effective pom is created and this is later used to define the dependencies:
> {code}final File[] longhand = Resolvers.use(MavenResolverSystem.class).configureFromPom("path/to/pom").resolve("G:A").offline()
>             .withTransitivity().as(File.class);{code}
> I don't think that delaying ".configureFromPom("path/to/pom").resolve("G:A")" call until MavenStrategyStage is reached in the right way to go, because that way we couldn't for instance cache already parsed POM file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira