[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-66) Allow "resolve" to take in Collection<String> and Collection<MavenDependency>

[Andrew Rubinger (JIRA)]

     [ https://issues.jboss.org/browse/SHRINKRES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Rubinger resolved SHRINKRES-66.
--------------------------------------

         Assignee: Andrew Rubinger
    Fix Version/s: 2.0.0-alpha-5
       Resolution: Done


Resolved discussion on GitHub.

Conclusion: "resolve" to accept String, String..., Collection<String>.  "addDependency" to accept MavenDependency, MavenDependency..., Collection<MavenDependency>.

Upstream: https://github.com/shrinkwrap/resolver/commit/908b0c3e9e1723fc983d5782b6c316d539000b34
                
> Allow "resolve" to take in Collection<String> and Collection<MavenDependency>
> -----------------------------------------------------------------------------
>
>                 Key: SHRINKRES-66
>                 URL: https://issues.jboss.org/browse/SHRINKRES-66
>             Project: ShrinkWrap Resolvers
>          Issue Type: Feature Request
>    Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3
>            Reporter: Andrew Rubinger
>            Assignee: Andrew Rubinger
>              Labels: starter
>             Fix For: 2.0.0-alpha-5
>
>
> From Craig Ringer:
> -----------
> Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a set or list then pass an array view of it to resolve(), eg given a Set artifacts:
> {code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new String[artifacts.size()])).withTransitivity().as(File.class));{code}
> -----------
> Save the user the extra step of having to convert Collections to an array by enhancing the API to accept Collections natively.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira