[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-469) ShrinkWrapDirectoryStream.iterator missing IllegalStateException cases

[Andrew Rubinger (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851101#comment-12851101 ] 

Andrew Rubinger commented on SHRINKWRAP-469:
--------------------------------------------

Thanks for the report; was there an associated PR?
                
> ShrinkWrapDirectoryStream.iterator missing IllegalStateException cases
> ----------------------------------------------------------------------
>
>                 Key: SHRINKWRAP-469
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-469
>             Project: ShrinkWrap
>          Issue Type: Bug
>            Reporter: Under Flowerpot
>            Priority: Minor
>
> Unfortunately the nio2 API was designed before Java8's stream library.
> The documentation says that ShrinkWrapDirectoryStream.iterator must throw IllegalStateException if the Stream is closed OR if the iterator() has been accessed already.
> From my reading of the DirectoryStream javadoc, the implementation of Iterator is otherwise fine. close() does not have to prematurely terminate the Iterator. iterator() should just comply with the precondition exceptions.
> ShrinkWrapDirectoryStream is package protected, there is no reason to discuss any relationship to SecureDirectoryStream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira