[shrinkwrap-issues] [JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

[Ralf Battenfeld (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12963114#comment-12963114 ] 

Ralf Battenfeld commented on SHRINKDESC-155:
--------------------------------------------

Thanks, George. I will have a look. What I can say is that the common descriptor approach cannot provide every possible common method. If we are able to generate 90% then we are in a very good shape. You can see in the pom.xml that the anchors for generating common classes, which are very specific for each descriptor and how many versions have to be generated.

I'll do my best.
Ralf
                
> Missing methods in generated common parents
> -------------------------------------------
>
>                 Key: SHRINKDESC-155
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-155
>             Project: ShrinkWrap Descriptors
>          Issue Type: Feature Request
>          Components: api-javaee
>    Affects Versions: 2.0.0-alpha-6
>            Reporter: George Gastaldi
>            Assignee: Ralf Battenfeld
>
> Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. 
> For example: 
> - JavaeeServletMappingCommonType
> -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webcommon/ServletMappingCommonType.java
> - WebAppCommonDescriptor
> -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp/WebAppCommonDescriptor.java
> Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira