[shrinkwrap-issues] [JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

Ralf Battenfeld (JIRA) issues at jboss.org
Mon Feb 24 04:19:47 EST 2014


    [ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12947211#comment-12947211 ] 

Ralf Battenfeld commented on SHRINKDESC-151:
--------------------------------------------

I quickly checked this and renamed the local repo folder. Here is what I get from jboss nexus:

[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building ShrinkWrap Descriptors Metadata Parser 2.0.0-alpha-6-SNAPSHOT
[INFO] ------------------------------------------------------------------------
Downloading: https://repository.jboss.org/nexus/content/groups/public/com/thoughtworks/qdox/qdox/2.0-SNAPSHOT/maven-metadata.xml
Downloaded: https://repository.jboss.org/nexus/content/groups/public/com/thoughtworks/qdox/qdox/2.0-SNAPSHOT/maven-metadata.xml (2 KB at 0.2 KB/sec)
Downloading: https://repository.jboss.org/nexus/content/groups/public/com/thoughtworks/qdox/qdox/2.0-SNAPSHOT/qdox-2.0-20130706.124819-8.pom
Downloaded: https://repository.jboss.org/nexus/content/groups/public/com/thoughtworks/qdox/qdox/2.0-SNAPSHOT/qdox-2.0-20130706.124819-8.pom (17 KB at 5.7 KB/sec)
Downloading: https://repository.jboss.org/nexus/content/groups/public/com/thoughtworks/qdox/qdox/2.0-SNAPSHOT/qdox-2.0-20130706.124819-8.jar
Downloaded: https://repository.jboss.org/nexus/content/groups/public/com/thoughtworks/qdox/qdox/2.0-SNAPSHOT/qdox-2.0-20130706.124819-8.jar (282 KB at 62.0 KB/sec)

I can't tell you why you don't see this but I do...
                
> Descriptors should generate a common parent for different spec versions
> -----------------------------------------------------------------------
>
>                 Key: SHRINKDESC-151
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-151
>             Project: ShrinkWrap Descriptors
>          Issue Type: Feature Request
>          Components: api-javaee
>            Reporter: George Gastaldi
>            Assignee: Ralf Battenfeld
>
> This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used.
> A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: 
> Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp/WebAppCommonDescriptor.java
> Sub Interfaces: 
> https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp25/WebAppDescriptor.java
> https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp30/WebAppDescriptor.java
> https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp31/WebAppDescriptor.java
> The generated code doesn't need to change either. The existence of the super interface is what matters most.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the shrinkwrap-issues mailing list