[shrinkwrap-issues] [JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions
George Gastaldi (JIRA)
issues at jboss.org
Wed Feb 26 05:05:49 EST 2014
[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12948229#comment-12948229 ]
George Gastaldi commented on SHRINKDESC-151:
--------------------------------------------
I'd go even further and remove the "Common" suffix from the generated classes (eg: ValidationDescriptor in org.jboss.shrinkwrap.descriptors.javaee.validation is the parent interface for the ValidationDescriptor in validation10 and validation11 subpackages). Makes sense? :)
> Descriptors should generate a common parent for different spec versions
> -----------------------------------------------------------------------
>
> Key: SHRINKDESC-151
> URL: https://issues.jboss.org/browse/SHRINKDESC-151
> Project: ShrinkWrap Descriptors
> Issue Type: Feature Request
> Components: api-javaee
> Reporter: George Gastaldi
> Assignee: Ralf Battenfeld
>
> This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used.
> A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface:
> Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp/WebAppCommonDescriptor.java
> Sub Interfaces:
> https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp25/WebAppDescriptor.java
> https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp30/WebAppDescriptor.java
> https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp31/WebAppDescriptor.java
> The generated code doesn't need to change either. The existence of the super interface is what matters most.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the shrinkwrap-issues
mailing list