[shrinkwrap-issues] [JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

[Ralf Battenfeld (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986484#comment-12986484 ] 

Ralf Battenfeld commented on SHRINKDESC-155:
--------------------------------------------

I think your proposal is already present. You can use any descriptor and used it regardless of the target version. What I mean is for example, you can take WebAppDescriptor 2.5 for generating web.xml for version 3.0 and 3.1. I don't see a different by using a common descriptor which is basically a clone of the first version.

I would like to introduce a new way of the common API for the next API, if that is happening...

> Missing methods in generated common parents
> -------------------------------------------
>
>                 Key: SHRINKDESC-155
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-155
>             Project: ShrinkWrap Descriptors
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: api-javaee
>    Affects Versions: 2.0.0-alpha-6
>            Reporter: George Gastaldi
>            Assignee: Ralf Battenfeld
>
> Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. 
> For example: 
> - JavaeeServletMappingCommonType
> -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webcommon/ServletMappingCommonType.java
> - WebAppCommonDescriptor
> -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp/WebAppCommonDescriptor.java
> Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. 



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)