[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-479) Use default file ending for Archives with defined name

[Aslak Knutsen (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12954785#comment-12954785 ] 

Aslak Knutsen commented on SHRINKWRAP-479:
------------------------------------------

btw, did you not see this warning from Arquillian?

https://github.com/arquillian/arquillian-core/blob/master/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/deployment/AnnotationDeploymentScenarioGenerator.java#L136
                
> Use default file ending for Archives with defined name
> ------------------------------------------------------
>
>                 Key: SHRINKWRAP-479
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-479
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>            Reporter: Thorben Janssen
>
> If the name of an ShrinkWrap archive is defined during creation, the name has to include the correct file ending to ensure correct deployment in the container, e.g.:
> ShrinkWrap.create(EnterpriseArchive.class, "MyArchive.ear");
> In most of the cases the file ending is the default file ending of the specified archive type. In these cases there is no need to specify the obvious and it is just a source of error.
> Suggested change:
> - Archive implementation defines default file ending
> - default file ending is added to the specified archive name by default (if it does not match the end of the specified name)
> - add additional method to support archives with none standard file endings, e.g.: ShrinkWrap.create(Class<T> type, String archiveName, boolean useDefaultFileEnding)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira