[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-480) Fix order of entries in exported zip file

Grzegorz Grzybek (JIRA) issues at jboss.org
Tue Sep 15 14:52:00 EDT 2015


    [ https://issues.jboss.org/browse/SHRINKWRAP-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108952#comment-13108952 ] 

Grzegorz Grzybek edited comment on SHRINKWRAP-480 at 9/15/15 2:51 PM:
----------------------------------------------------------------------

Here's a difference between JDK7 and JDK8:
!jdk7-8.png|thumbnail!
I have simple:
{code:java}
        final JavaArchive archive = ShrinkWrap.create(JavaArchive.class, "migrator-1.0.1.jar");
        archive.setManifest(new Asset() {
            public InputStream openStream() {
                OSGiManifestBuilder builder = OSGiManifestBuilder.newInstance();
                builder.add...
                return builder.openStream();
            }
        });
        archive.addClass(ExampleMigrator.class);
{code}

shouldn't {{org.jboss.shrinkwrap.impl.base.MemoryMapArchiveBase#content}} field be LinkedHashMap?


was (Author: grgrzybek):
Here's a difference between JDK7 and JDK8:
!jdk7-8.png!
I have simple:
{code:java}
        final JavaArchive archive = ShrinkWrap.create(JavaArchive.class, "migrator-1.0.1.jar");
        archive.setManifest(new Asset() {
            public InputStream openStream() {
                OSGiManifestBuilder builder = OSGiManifestBuilder.newInstance();
                builder.add...
                return builder.openStream();
            }
        });
        archive.addClass(ExampleMigrator.class);
{code}

shouldn't {{org.jboss.shrinkwrap.impl.base.MemoryMapArchiveBase#content}} field be LinkedHashMap?

> Fix order of entries in exported zip file
> -----------------------------------------
>
>                 Key: SHRINKWRAP-480
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-480
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: impl-base
>    Affects Versions: 1.2.2
>            Reporter: Stefan Bunciak
>            Assignee: Michal Matloka
>         Attachments: jdk7-8.png
>
>
> ZipExporter from ShwinkWrap 1.0.1 created zip file with the following structure:
> {code}
> Archive:  s-ramp-exporter.jar
>  Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
> --------  ------  ------- ---- ---------- ----- --------  ----
>        0  Defl:N        2   0% 03-31-2014 13:36 00000000  META-INF/
>     3847  Defl:N      898  77% 03-31-2014 13:36 b04e8666  META-INF/switchyard.xml
>        0  Defl:N        2   0% 03-31-2014 13:36 00000000  META-INF/beans.xml
>        0  Defl:N        2   0% 03-31-2014 13:36 00000000  org/
>        0  Defl:N        2   0% 03-31-2014 13:36 00000000  org/jboss/
>        0  Defl:N        2   0% 03-31-2014 13:36 00000000  org/jboss/arquillian/
>        0  Defl:N        2   0% 03-31-2014 13:36 00000000  org/jboss/arquillian/container/
>        0  Defl:N        2   0% 03-31-2014 13:36 00000000  org/jboss/arquillian/container/sramp/
>     1881  Defl:N      875  54% 03-31-2014 13:36 21ed2654  org/jboss/arquillian/container/sramp/DeploymentTest.class
> --------          -------  ---                            -------
>     5728             1787  69%                            9 files
> {code}
> Newer versions on ShrinkWrap gave me:
> {code}
> Archive:  s-ramp-resource.jar
>  Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
> --------  ------  ------- ---- ---------- ----- --------  ----
>     3847  Defl:N      898  77% 03-30-2014 17:45 b04e8666  META-INF/switchyard.xml
>        0  Defl:N        2   0% 03-30-2014 17:45 00000000  org/jboss/
>        0  Defl:N        2   0% 03-30-2014 17:45 00000000  META-INF/beans.xml
>        0  Defl:N        2   0% 03-30-2014 17:45 00000000  org/jboss/arquillian/container/
>     1790  Defl:N      842  53% 03-30-2014 17:45 7a7ed211  org/jboss/arquillian/container/sramp/DeploymentTest.class
>        0  Defl:N        2   0% 03-30-2014 17:45 00000000  org/jboss/arquillian/container/sramp/
>        0  Defl:N        2   0% 03-30-2014 17:45 00000000  META-INF/
>        0  Defl:N        2   0% 03-30-2014 17:45 00000000  org/jboss/arquillian/
>        0  Defl:N        2   0% 03-30-2014 17:45 00000000  org/
> --------          -------  ---                            -------
>     5637             1754  69%                            9 files
> {code}
> Would it be possible to provide users with both exporting mechanisms (single & multi threaded)? By default use the multi-threaded approach.
> I assume this behavior is result of https://issues.jboss.org/browse/SHRINKWRAP-434. It's not against ZIP standard, afaik, however due to such structure I had to revert to older version of ShrinkWrap (I need zip file for further processing by 3rd party library)



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)


More information about the shrinkwrap-issues mailing list