[teiid-designer-dev] [Teiid-Designer/teiid-designer] 15fde6: TEIIDDES-1947: Adds workaround for Group layout is...

[Paul Richardson]

  Branch: refs/heads/master
  Home:   https://github.com/Teiid-Designer/teiid-designer
  Commit: 15fde65574800dba53318164d54b93aec1237231
      https://github.com/Teiid-Designer/teiid-designer/commit/15fde65574800dba53318164d54b93aec1237231
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2013-12-04 (Wed, 04 Dec 2013)

  Changed paths:
    M plugins/org.teiid.designer.advisor.ui/src/org/teiid/designer/advisor/ui/dialogs/DefineSourceDialog.java
    M plugins/org.teiid.designer.datatools.ui/src/org/teiid/designer/datatools/profiles/xml/XmlLocalFileProfileDetailsWizardPage.java
    M plugins/org.teiid.designer.diagram.ui/src/org/teiid/designer/diagram/ui/preferences/DiagramPreferencePage.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/connection/SelectJndiDataSourceDialog.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/connection/SelectTranslatorDialog.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/vdb/DeployVdbDialog.java
    M plugins/org.teiid.designer.jdbc.ui/src/org/teiid/designer/jdbc/ui/wizards/JdbcSourceSelectionPage.java
    M plugins/org.teiid.designer.modelgenerator.ldap.ui/src/org/teiid/designer/modelgenerator/ldap/ui/wizards/pages/definition/SourceModelPanel.java
    M plugins/org.teiid.designer.modelgenerator.salesforce.ui/src/org/teiid/designer/modelgenerator/salesforce/ui/wizards/CredentialsPage.java
    M plugins/org.teiid.designer.modelgenerator.salesforce.ui/src/org/teiid/designer/modelgenerator/salesforce/ui/wizards/ModelSelectionPage.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/SelectWsdlPage.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/soap/OperationsDetailsPage.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/soap/WsdlDefinitionPage.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/soap/panels/ColumnsInfoPanel.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/soap/panels/ElementsInfoPanel.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/soap/panels/ImportOptionsPanel.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/soap/panels/RequestSchemaContentsGroup.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/soap/panels/ResponseSchemaContentsGroup.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/soap/panels/WrapperProcedurePanel.java
    M plugins/org.teiid.designer.modelgenerator.wsdl.ui/src/org/teiid/designer/modelgenerator/wsdl/ui/wizards/soap/panels/WsdlOperationsPanel.java
    M plugins/org.teiid.designer.modelgenerator.xml/src/org/teiid/designer/modelgenerator/xml/wizards/IntroductionPage.java
    M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/EditForeignKeyDialog.java
    M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/EditIndexDialog.java
    M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalTableEditorPanel.java
    M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/wizards/RelationalModelTextImporterMainPage.java
    M plugins/org.teiid.designer.roles.ui/src/org/teiid/designer/roles/ui/wizard/dialogs/SelectObjectDialog.java
    M plugins/org.teiid.designer.roles.ui/src/org/teiid/designer/roles/ui/wizard/panels/ColumnMaskingPanel.java
    M plugins/org.teiid.designer.roles.ui/src/org/teiid/designer/roles/ui/wizard/panels/RowBasedSecurityPanel.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/panels/CreateDataSourcePanel.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/panels/ImportPropertiesPanel.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/SelectDataSourcePage.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/SelectTranslatorAndTargetPage.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/ShowDDLPage.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/DefineViewProcedureDialog.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/ViewProcedureEditorPanel.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/ViewTableEditorPanel.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/reconciler/SqlTablePanel.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/reconciler/datatype/DatatypeReconcilerPanel.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/search/TransformationSearchPanel.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/DelimiterOptionsDialog.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/ParsedDataRowDialog.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/TeiidFlatFileImportOptionsPage.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/TeiidMetadataImportFormatPage.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/TeiidMetadataImportOptionsPage.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/TeiidMetadataImportSourcePage.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/TeiidMetadataImportViewModelPage.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/TextTableFunctionOptionsDialog.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/sqlbuilder/SQLTemplateDialog.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/xmlfile/TeiidXmlConnectionOptionsDialog.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/xmlfile/TeiidXmlImportOptionsPage.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/xmlfile/TeiidXmlImportSourcePage.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/xmlfile/TeiidXmlImportXmlConfigurationPage.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/xmlfile/panels/ColumnsInfoPanel.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/xmlfile/panels/XmlFileContentsGroup.java
    M plugins/org.teiid.designer.ui.common/src/org/teiid/designer/ui/common/util/WidgetFactory.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/preferences/GeneralPreferencePage.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/views/EditDescriptionDialog.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/editor/ShowImportVdbsDialog.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/editor/panels/PropertiesPanel.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/wizards/NewVdbWizard.java
    M plugins/org.teiid.designer.webservice.ui/src/org/teiid/designer/webservice/ui/wizard/WsdlSelectionPage.java

  Log Message:
  -----------
  TEIIDDES-1947: Adds workaround for Group layout issues

* There appears to be a bug in the SWT Group widget where dialogs are not
  layed out correctly when first displayed. If the Group has a title, the
  group's content overlaps it and likewise can sometimes be truncated at
  the bottom.

* WidgetFactory
 * By setting the top margin to a value of '10' the overlapping and
   truncation is removed. However, in some cases the margins are correctly
   observed hence a 10 point gap is displayed under the group title. Thus,
   this remains a workaround and not a complete solution.

* Where components make use of WidgetFactory.createGroup, ensures that they
  do not override the layout.