[teiid-designer-dev] [Teiid-Designer/teiid-designer] f25cd0: Fixes build script dependency building

Paul Richardson p.g.richardson at redhat.com
Fri Sep 13 11:17:52 EDT 2013


  Branch: refs/heads/8.2.x
  Home:   https://github.com/Teiid-Designer/teiid-designer
  Commit: f25cd0d1a25dac27e169e6bb83914dc0d074f15f
      https://github.com/Teiid-Designer/teiid-designer/commit/f25cd0d1a25dac27e169e6bb83914dc0d074f15f
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2013-09-13 (Fri, 13 Sep 2013)

  Changed paths:
    M plugins/teiid/org.teiid.7.7.x
    M plugins/teiid/org.teiid.8.3.x
    M plugins/teiid/org.teiid.8.4.x

  Log Message:
  -----------
  Fixes build script dependency building

* Updates the repo to point to the new commits on the sub-modules relating
  to fixing the build script dependency issue.

* Comments on sub module commits
 * For mvn process-sources to work correctly in eclipse, it is necessary to
   also build the org.teiid.datatools plugins. If these have not been
   previously built in the local mvn repo then the auto-builder in Eclipse
  fails.

 * This is annoying since these plugins are only required for the tycho TP
   which is not even executed during the process-sources phase. An Eclipse
   bug is currently open for this issue at
   https://bugs.eclipse.org/bugs/show_bug.cgi?id=353889

 * Removes the unnecessary generate-javacc profile since it is no longer
   used or initiated.


  Commit: 15b1f1071e3d2b8ccf87f82bd8bafc9eab31b2e6
      https://github.com/Teiid-Designer/teiid-designer/commit/15b1f1071e3d2b8ccf87f82bd8bafc9eab31b2e6
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2013-09-13 (Fri, 13 Sep 2013)

  Changed paths:
    M plugins/org.teiid.datatools.connectivity.ui/META-INF/MANIFEST.MF
    M plugins/org.teiid.datatools.connectivity.ui/build.xml
    M plugins/org.teiid.datatools.connectivity.ui/plugin.xml
    R plugins/org.teiid.datatools.connectivity.ui/src/org/teiid/datatools/connectivity/ui/preferences/EnableQueryPlanPreferenceContributor.java
    M plugins/org.teiid.designer.dqp.ui/plugin.xml
    A plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/preferences/EnableQueryPlanPreferenceContributor.java

  Log Message:
  -----------
  Datatools plugins cannot depend on Teiid UI plugins

* The plugins prefixed with org.teiid.datatools are part of a feature that
  is not dependent on other teiid features. In fact, this feature is
  depended on by all the other teiid features.

* Moves the EnableQueryPlanPreferenceContributor into the dpq UI plugin
  along with the other preferences. This is not perfect since the query
  plans are dealt with mostly in the datatools.connectivity plugins.
  However, it only sets a global preference so is not fatal and solves the
  circular dependency that has to be removed.


Compare: https://github.com/Teiid-Designer/teiid-designer/compare/3a12709b1f88...15b1f1071e3d


More information about the teiid-designer-dev mailing list