[teiid-designer-dev] [Teiid-Designer/teiid-designer] ec960f: TEIIDDES-2120: Fix and add VDB unit tests

Paul Richardson p.g.richardson at redhat.com
Fri Jun 13 07:07:29 EDT 2014


  Branch: refs/heads/TEIIDDES-2120
  Home:   https://github.com/Teiid-Designer/teiid-designer
  Commit: ec960f8feec70f0036897090cf51c9370a47b7a8
      https://github.com/Teiid-Designer/teiid-designer/commit/ec960f8feec70f0036897090cf51c9370a47b7a8
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/Vdb.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbConstants.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbUtil.java
    M tests/org.teiid.designer.core.test.framework/src/org/teiid/designer/core/workspace/MockFileBuilder.java
    M tests/org.teiid.designer.vdb.test/src/org/teiid/designer/vdb/VdbFileEntryTest.java
    M tests/org.teiid.designer.vdb.test/src/org/teiid/designer/vdb/VdbTest.java
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/META-INF/vdb.xml
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/Test_TEIIDDES_2120/BookDatatypes.xsd
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/Test_TEIIDDES_2120/Books.xmi
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/Test_TEIIDDES_2120/Books.xsd
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/Test_TEIIDDES_2120/BooksXML.xmi
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/books.vdb
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/runtime-inf/2000970593.INDEX
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/runtime-inf/2177535116.INDEX
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/runtime-inf/3418690534.INDEX
    A tests/org.teiid.designer.vdb.test/testdata/books.vdb.project/runtime-inf/3719569411.INDEX

  Log Message:
  -----------
  TEIIDDES-2120: Fix and add VDB unit tests

* Vdb
 * Utilise VdbConstants
 * Ensures that the full path of the vdb's file does not duplicate the
   path of the tmp folder when saving occurs

* MockFileBuilder
 * 1-stop class for mocking a path, its related IFile and underpinned by a
   real file

* VdbFileEntryTest
* VdbTest
 * Fixes tests to cope with more calls to the mocked paths
 * New tests for exploring the functionality of the vdb


  Commit: 63848dbd47b34ea2258846bc38bcd2e58c875114
      https://github.com/Teiid-Designer/teiid-designer/commit/63848dbd47b34ea2258846bc38bcd2e58c875114
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2014-06-13 (Fri, 13 Jun 2014)

  Changed paths:
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/Vdb.java

  Log Message:
  -----------
  TEIIDDES-2120: Erroneous relativising of path value

* Seems making the path relative to the tmp folder is not a good idea
  since it adds a ../ to its beginning. This causes the createTempFile
  method to fail.

* Causes preview vdbs creation to fail with a "no such file or directory"
  error

* Originally added to stop path being a full duplication of tmpFolder,
  which occurred in some unit tests. However, this does not seem to be
  repeated so removing.


Compare: https://github.com/Teiid-Designer/teiid-designer/compare/48d2893aafd4...63848dbd47b3


More information about the teiid-designer-dev mailing list