[teiid-issues] [JBoss JIRA] Commented: (TEIID-254) Metadata query for procedure columns needs work

[Steven Hawkins (JIRA)]

    [ https://jira.jboss.org/jira/browse/TEIID-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12476062#action_12476062 ] 

Steven Hawkins commented on TEIID-254:
--------------------------------------

The simplest fix would be to change the System.ProcedureParams query from 

SELECT DISTINCT p.ModelName, PROC_NAME AS ProcedureName, pp.NAME AS Name, RUNTIME_TYPE_NAME AS DataType, POSITION, lookup('SystemPhysical.PROC_PARAM_TYPE_ENUM', 'NAME', 'CODE', DIRECTION) AS Type, is_optional AS Optional, PRECISION, LENGTH AS TypeLength, SCALE, RADIX, lookup('SystemPhysical.NULL_TYPE_ENUM', 'NAME', 'CODE', NULL_TYPE) AS NullType FROM (SELECT SystemPhysical.PROC_PARAMS.PROC_NAME, SystemPhysical.PROC_PARAMS.NAME, SystemPhysical.PROC_PARAMS.RUNTIME_TYPE_NAME, SystemPhysical.PROC_PARAMS.POSITION, convert(SystemPhysical.PROC_PARAMS.DIRECTION, integer) AS DIRECTION, SystemPhysical.PROC_PARAMS.IS_OPTIONAL, SystemPhysical.PROC_PARAMS.PRECISION, SystemPhysical.PROC_PARAMS.LENGTH, SystemPhysical.PROC_PARAMS.SCALE, SystemPhysical.PROC_PARAMS.RADIX, SystemPhysical.PROC_PARAMS.NULL_TYPE, SystemPhysical.PROC_PARAMS.PROC_UUID FROM SystemPhysical.PROC_PARAMS UNION ALL SELECT rs.PROC_NAME, c.NAME, c.RUNTIME_TYPE_NAME, c.POSITION, 4, {b'false'}, c.PRECISION, c.LENGTH, c.SCALE, c.RADIX, c.NULL_TYPE, rs.PROC_UUID FROM SystemPhysical.PROC_RESULT_SETS AS rs, SystemPhysical.COLUMNS AS c WHERE rs.UUID = c.PARENT_UUID) AS pp, System.Procedures AS p WHERE PROC_UUID = p.UID

to 

SELECT DISTINCT p.ModelName, p.FullName AS ProcedureName, pp.NAME AS Name, RUNTIME_TYPE_NAME AS DataType, POSITION, lookup('SystemPhysical.PROC_PARAM_TYPE_ENUM', 'NAME', 'CODE', DIRECTION) AS Type, is_optional AS Optional, PRECISION, LENGTH AS TypeLength, SCALE, RADIX, lookup('SystemPhysical.NULL_TYPE_ENUM', 'NAME', 'CODE', NULL_TYPE) AS NullType FROM (SELECT  SystemPhysical.PROC_PARAMS.NAME, SystemPhysical.PROC_PARAMS.RUNTIME_TYPE_NAME, SystemPhysical.PROC_PARAMS.POSITION, convert(SystemPhysical.PROC_PARAMS.DIRECTION, integer) AS DIRECTION, SystemPhysical.PROC_PARAMS.IS_OPTIONAL, SystemPhysical.PROC_PARAMS.PRECISION, SystemPhysical.PROC_PARAMS.LENGTH, SystemPhysical.PROC_PARAMS.SCALE, SystemPhysical.PROC_PARAMS.RADIX, SystemPhysical.PROC_PARAMS.NULL_TYPE, SystemPhysical.PROC_PARAMS.PROC_UUID FROM SystemPhysical.PROC_PARAMS UNION ALL SELECT c.NAME, c.RUNTIME_TYPE_NAME, c.POSITION, 4, {b'false'}, c.PRECISION, c.LENGTH, c.SCALE, c.RADIX, c.NULL_TYPE, rs.PROC_UUID FROM SystemPhysical.PROC_RESULT_SETS AS rs, SystemPhysical.COLUMNS AS c WHERE rs.UUID = c.PARENT_UUID) AS pp, System.Procedures AS p WHERE PROC_UUID = p.UID

so that the the searchable p.FullName is used as the ProcedureName.


> Metadata query for procedure columns needs work
> -----------------------------------------------
>
>                 Key: TEIID-254
>                 URL: https://jira.jboss.org/jira/browse/TEIID-254
>             Project: Teiid
>          Issue Type: Task
>          Components: Query Engine
>    Affects Versions: 6.0.0
>            Reporter: Steven Hawkins
>             Fix For: 6.2.0
>
>
> Defect Tracker #24885: Even if procedure name criteria is supplied for the QUERY_PROCEDURE_COLUMNS, it is applied to a synthetic column - which can only be processed after all rows are retrieved.  It looks like there may be other procedure name values in the system tables that would be a better place for this criteria (or at least more join criteria could be added under the ProcedureParams query)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira