[teiid-issues] [JBoss JIRA] Resolved: (TEIID-743) Excessive cloning of connector binding properties

[Ramesh Reddy (JIRA)]

     [ https://jira.jboss.org/jira/browse/TEIID-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramesh Reddy resolved TEIID-743.
--------------------------------

    Resolution: Done


Nested property resolution moved to Connector Manager initialization code. The property that represents the "deploy.properties" is initialized with "system.getProperties" as the default value properties object for full set of properties available for the system. 

Cached and created the hierarchy for the Connector Type properties. Connector binding creates a new property object using this property object as the default value property object, thus avoiding cloning and sharing of the properties object.

> Excessive cloning of connector binding properties
> -------------------------------------------------
>
>                 Key: TEIID-743
>                 URL: https://jira.jboss.org/jira/browse/TEIID-743
>             Project: Teiid
>          Issue Type: Bug
>          Components: Common
>    Affects Versions: 6.1.0
>            Reporter: Ramesh Reddy
>            Assignee: Ramesh Reddy
>             Fix For: 6.2.0
>
>
> The connector binding properties are excessively being cloned at each level, which leads to lot if memory overhead. In the case of handling the hundreds of connector bindings this will result in OOM. 
> 1) The connector binding properties does not have access to the configuration level properties (properties in deploy.properties)
> 2) Default property mechanism not being used.  When you create a properties object  like "new Properties(defaultProps)", the defaultProps object properties are not copied into the container properties object, nor they can be changed. They can be overridden, but will not affect the defaultProps object.
> 3) Properties not being cached
> For (2) connector binding properties need to be layered such that the connector binding property tree object will look like
> system properties
>        |-------------------------> deploy.properties
>                                                        |------------------> Connector Type Properties 
>                                                                                                     |----------------------------> Connector Binding Properties
> For (3) since up to the "Connector Type Properties", are common for a given Connector Binding they should be cached to minimize the memory overhead.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira