[teiid-issues] [JBoss JIRA] Resolved: (TEIID-839) adminAPI shutdown method gets NPE and does not shut down the server

[Ramesh Reddy (JIRA)]

     [ https://jira.jboss.org/jira/browse/TEIID-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramesh Reddy resolved TEIID-839.
--------------------------------

    Resolution: Done


There were couple issues in this defect

1) Admin connection do not have vdb-name and vdb-version properties in the connection properties. Especially with server deployments. Although Teiid has unit tests they were written using embedded. So, this issue only occurs on "server" mode with "admin" connections only.

2) The repeated log entry saying session "0" is invalid. This happens when server is shutdown or killed and the reconnecting proxy that Teiid uses for "admin" connections tries to re-connect to server. When this proxy makes the new connection, it tries to validate the old session on the new connection. Since server no longer recognises the old session, it throws the exception. This exception results in invalid operation and set off a "logoff" call that also needs a valid connection to be sucessful. So, the assertion of the "session" in effect done in loop, where each "logoff" results in another check, which kicks off another "logoff"

Now it has been corrected such that in the case of lost connections, the connection object is properly recycled does not try to log off a invalid session. 

3) The Reconnecting proxy also tries to make a new connection on occurrence "communication" exceptions before throwing a exception. This helps to re-establish the connection if the server went down and came back up in-between client calls.

> adminAPI shutdown method gets NPE and does not shut down the server
> -------------------------------------------------------------------
>
>                 Key: TEIID-839
>                 URL: https://jira.jboss.org/jira/browse/TEIID-839
>             Project: Teiid
>          Issue Type: Bug
>          Components: AdminApi
>    Affects Versions: 6.2.0
>         Environment: fedora 10, Teiid 6.2 RC1
>            Reporter: Paul Nittel
>            Assignee: Ramesh Reddy
>             Fix For: 6.2.0
>
>         Attachments: ShutDownErrors.zip
>
>
> How to reproduce:
> 1 - Start Teiid Server
> 2 - Start AdminShell
> 3 - connectAsAdmin to the running server
> 4 - shutdown(1000);
> AdminShell disconnects, but the server remains up. (You can reconnect via AdminShell.) As I was getting the log to paste the NPE here, the server burped out a couple of MB of junk. Now I'll attach the logs.
> Start reading teiid.log.1 at line 3414.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira