[teiid-issues] [JBoss JIRA] Commented: (TEIID-1190) Procedure logic clean up

[Steve Hawkins (JIRA)]

    [ https://jira.jboss.org/browse/TEIID-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12543590#action_12543590 ] 

Steve Hawkins commented on TEIID-1190:
--------------------------------------

Also the notion of a subcommand in a procedure is complicated. If the command is directly an argument of a Assigment/RaiseError/Declare/Loop/Command it's not a subcommand.  This means that other subcommands skip having virtual group resolution run.  It would be better if every command were a subcommand and deep/recursive navigation were used when appropriate.

> Procedure logic clean up
> ------------------------
>
>                 Key: TEIID-1190
>                 URL: https://jira.jboss.org/browse/TEIID-1190
>             Project: Teiid
>          Issue Type: Quality Risk
>          Components: Query Engine
>    Affects Versions: 7.1
>            Reporter: Steve Hawkins
>            Assignee: Steve Hawkins
>             Fix For: 7.1
>
>
> The procedure planning logic has several issues that should be addressed
> 1. RaiseErrorStatement extends AssignmentStatement, which is confusing the designer code.
> 2. Assigment/RaiseError/Declare have lots of specialized logic for dealing with commands.  It would be much simplier to just use a scalar subquery to represent the command execution.  This may need to be refined later if we want specialized handling for using the return value from storedprocedures and to use its cursor.
> 3. Validation is not run on dynamic sql commands.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira