[teiid-issues] [JBoss JIRA] (TEIID-2057) Problem with dynamic VDB re-deploy when it contains a Virtual Model

[Steven Hawkins (JIRA)]

    [ https://issues.jboss.org/browse/TEIID-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700330#comment-12700330 ] 

Steven Hawkins commented on TEIID-2057:
---------------------------------------

After looking things over more a full parse/save cycle doesn't seem like the right way to go.  To disentangle things better, there are several somewhat relate issues we have to address:
- vdb saved state needs to be complete.  the ddl or other necessary information cannot be ommitted.  The simplest approach with the current logic would be to just leave the ddl on the model.  We could consider adding an option for dynamic deployment as a zip and allow the ddl text file to be referenced in the zip.
- the vdb saved state should not carry over any errors from the runtime state.  For this we may want to consider not using the model error mechanism at all for runtime errors.  At least for metadata load an error is no longer necessary to track completion.
- modifications to the runtime/metadata state need to be made in a thread-safe manner.  for example mapped data role names are held by just an ArrayList without synchronization.
- we need to differentiate between vdb modifications that require a vdb restart (an operation that we should add) and those that have an immediate effect.  At the extreme of fully parsing/re-saving the metadata state of the vdb.xml with each operation there would be no runtime effect.

Ramesh,

Are the mutative methods on VDBService (such as addDataRole) used?  I see the same logic also in the TeiidOperationHandler and both make the problematic calls to save the vdb state.
                
> Problem with dynamic VDB re-deploy when it contains a Virtual Model
> -------------------------------------------------------------------
>
>                 Key: TEIID-2057
>                 URL: https://issues.jboss.org/browse/TEIID-2057
>             Project: Teiid
>          Issue Type: Bug
>          Components: AdminApi
>    Affects Versions: 8.0
>            Reporter: Mark Drilling
>            Assignee: Ramesh Reddy
>
> I am using the AdminAPI to add a View Model to a dynamic VDB.  The initial deployment succeeds - the VDB deploys and i can query the View.
> However, then I retrieve the VDB via the Admin API.  In debug, I can see on the view model - that the schemaText field is now null.  If I attempt to make other changes and re-deploy, the re-deploy fails - the parser chokes on the null schemaText

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira