[teiid-issues] [JBoss JIRA] (TEIID-2567) issues with permission element in vdb-deployer.xsd contains problematic choice node

[Steven Hawkins (JIRA)]

    [ https://issues.jboss.org/browse/TEIID-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787966#comment-12787966 ] 

Steven Hawkins commented on TEIID-2567:
---------------------------------------

> what is drawback in having the "allows-language" with other allows? It is just scope issue that it needs to defined at permission level?

The drawback is just a clarity issue.  Grouping the allows by object type is a generally a good idea.

> 1) If you don't foresee any more "choices" or resource types for permissions, then I'd vote for attributes.

We will add more types and allows as needed.

> 2) If you do think you'll add more choices, then I'd convert the <sequence> to a named type and I'm pretty sure JAXB could handle it.

Are you implying then that you are not in favor of just putting all of the allow elements under the same sequence and/or can you provide an example of what you mean?
                
> issues with permission element in vdb-deployer.xsd contains problematic choice node
> -----------------------------------------------------------------------------------
>
>                 Key: TEIID-2567
>                 URL: https://issues.jboss.org/browse/TEIID-2567
>             Project: Teiid
>          Issue Type: Task
>    Affects Versions: 8.4
>            Reporter: Barry LaFond
>            Assignee: Steven Hawkins
>             Fix For: 8.4.1
>
>
> Having a lot of trouble trying to tweak our JaxB VDB element classes to accommodate the permission's choice node which contains a <sequence> and an <element>.
> This structure is basically impossible to unmarshall using JAXB annotations (i.e. @XmlElements(value= {}) )
> Would clean things up to convert the <allow-language> element to an attribute:  <xs:attribute name="allow-language" type="xs:boolean"/> and place it on the <permission> element AND remove the <choice> node entirely

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira