[teiid-issues] [JBoss JIRA] (TEIID-2567) issues with permission element in vdb-deployer.xsd contains problematic choice node

[Steven Hawkins (JIRA)]

    [ https://issues.jboss.org/browse/TEIID-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788015#comment-12788015 ] 

Steven Hawkins commented on TEIID-2567:
---------------------------------------

Yes, I spoke too quickly.  An extra element is not desirable.  

> We can manage the limitations/issues with allowable choices for attributes in Designer/VDB Editor, if attributes are a cleaner for you guys.

Attributes aren't inherently "cleaner" it's just if we were to pursue that change we would make things more concise from an xml perspective:

{code}
<grant on="table" name="x.foo" select="true" insert="true"/>
{code}

vs.

{code}
<permission>
  <resource-name>x.foo</resource-name>
  <allow-read>true</allow-read>
  <allow-create>true</allow-create>
</permission>
{code}

longer term though we should have DDL support so this is just an intermediate state.  I'm fine if we just put all of the allows under a single sequence for now.
                
> issues with permission element in vdb-deployer.xsd contains problematic choice node
> -----------------------------------------------------------------------------------
>
>                 Key: TEIID-2567
>                 URL: https://issues.jboss.org/browse/TEIID-2567
>             Project: Teiid
>          Issue Type: Task
>    Affects Versions: 8.4
>            Reporter: Barry LaFond
>            Assignee: Steven Hawkins
>             Fix For: 8.4.1
>
>
> Having a lot of trouble trying to tweak our JaxB VDB element classes to accommodate the permission's choice node which contains a <sequence> and an <element>.
> This structure is basically impossible to unmarshall using JAXB annotations (i.e. @XmlElements(value= {}) )
> Would clean things up to convert the <allow-language> element to an attribute:  <xs:attribute name="allow-language" type="xs:boolean"/> and place it on the <permission> element AND remove the <choice> node entirely

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira