[teiid-issues] [JBoss JIRA] (TEIID-2909) Provide more info for TeiidPropertyDefinition marked 'isRequired' but with conditions

[Mark Drilling (JIRA)]

    [ https://issues.jboss.org/browse/TEIID-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12957469#comment-12957469 ] 

Mark Drilling commented on TEIID-2909:
--------------------------------------

going back to the google source, consider these properties:
AuthMethod (isRequired=true)
Username (isRequired=true)
Password (isRequired=true)
RefreshToken (isRequired=true)
According to the documentation, Username and Password are only required if AuthMethod=ClientLogin .  Similarly, RefreshToken is only required if AuthMethod=OAuth2.  

So in #1 , are you saying the above definitions are wrong and need fixing under current implementation?   How would they be changed?
#2 - The property descriptions for the above are empty.  Even if they had descriptions, that is insufficient for us to data drive our tooling.

Heres a possible solution:
AuthMethod (isRequired=true)
Username (isRequired=true, requiredWhen='AuthMethod=ClientLogin')
Password (isRequired=true, requiredWhen='AuthMethod=ClientLogin')
RefreshToken (isRequired=true, requiredWhen='AuthMethod=OAuth2')


                
> Provide more info for TeiidPropertyDefinition marked 'isRequired' but with conditions
> -------------------------------------------------------------------------------------
>
>                 Key: TEIID-2909
>                 URL: https://issues.jboss.org/browse/TEIID-2909
>             Project: Teiid
>          Issue Type: Feature Request
>          Components: AdminApi
>    Affects Versions: 8.4
>            Reporter: Mark Drilling
>            Assignee: Steven Hawkins
>
> For some data source types, there are associated propertyDefinitions that are marked 'required'.  However, they are not always required.
> I'm referring to TeiidPropertyDefinition list returned by adminApi.getTemplatePropertyDefns(), for example.
> Google source is example of a source containing this type of property definition.  
> https://docs.jboss.org/author/display/teiid84final/Google+Spreadsheet+Data+Sources
> For example 'RefreshToken' is marked as required, but it is only required based on the value of another property (AuthMethod).
> Can teiid provide these additional conditions along with the propertyDefinition?  Without this information we are forced to hard-code the validation rules into our client application.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira