[teiid-issues] [JBoss JIRA] (TEIID-3948) Provide a different mechanism to update odata wars

[Ramesh Reddy (JIRA)]

    [ https://issues.jboss.org/browse/TEIID-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163807#comment-13163807 ] 

Ramesh Reddy commented on TEIID-3948:
-------------------------------------

>The cli scripts are already in charge of doing the war deployments and a modification to override the web.xml would be a copy/paste exercise (or just commented out in the cli script file).

yes, this is happening by install scripts, but what we are talking about is by the user. My worry is web.xml is not the only thing that might require change. In the case of the oauth/saml there were certificates to be added, jboss-web.xml and additional keycloak configuration files etc. I do not like to set a different way to handle this simple case and then do the other way for rest of the usecases.

>Can you elaborate on that? Do you mean that it's better to have a self contained artifact?
These changes will not be part of the WAR file, but they will exist in the "deployments" folder some how. Now when one migrates to a different server or newer version then the burden is on us to move these appropriately. What I am saying let the user own the changes, in self contained WAR file, then it is matter of just moving their artifact to a newer server. 

>You mean if you rely on embedded and have a separate kitting option for EAP/AS. It still seems heavy weight for users to then do a git checkout, modification, and maven build to just >update properties in the web.xml.

This embedded option as you say is for different purpose than this, that is for us to promote ourselves as drop-in OData provider (in any JEE container) for any datasource. Here, I am just laying out a usecase as to why we would need to move OData project to a separate repo, not for this individual issue.


> Provide a different mechanism to update odata wars
> --------------------------------------------------
>
>                 Key: TEIID-3948
>                 URL: https://issues.jboss.org/browse/TEIID-3948
>             Project: Teiid
>          Issue Type: Quality Risk
>          Components: Server
>            Reporter: Steven Hawkins
>            Assignee: Steven Hawkins
>             Fix For: 9.0, 8.12.5
>
>
> Directly modifying the wars under the base modules is a bad practice.  We need to have users modify non-kit artifact files in a different location.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)