[teiid-issues] [JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row

[David Vilaverde (JIRA)]

     [ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Vilaverde updated TEIID-4883:
-----------------------------------
    Description: 
The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name.  In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.

The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.


I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951

If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?



  was:
The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name.  In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.

The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.


I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951



> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
>                 Key: TEIID-4883
>                 URL: https://issues.jboss.org/browse/TEIID-4883
>             Project: Teiid
>          Issue Type: Enhancement
>          Components: Misc. Connectors
>            Reporter: David Vilaverde
>            Assignee: Steven Hawkins
>            Priority: Minor
>             Fix For: Open To Community
>
>         Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name.  In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)