[teiid-issues] [JBoss JIRA] (TEIID-4572) Grouping by and faceted search for Solr tranlator

[Amr Ismail (JIRA)]

    [ https://issues.jboss.org/browse/TEIID-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412655#comment-13412655 ] 

Amr Ismail commented on TEIID-4572:
-----------------------------------

any updates

On May 24, 2017 1:28 PM, "Steven Hawkins (JIRA)" <issues at jboss.org> wrote:

Steven Hawkins
<https://issues.jboss.org/secure/ViewProfile.jspa?name=shawkins> *commented*
on [image: Enhancement] TEIID-4572
<https://issues.jboss.org/browse/TEIID-4572>

Re: Grouping by and faceted search for Solr tranlator
<https://issues.jboss.org/browse/TEIID-4572>

As mentioned on the original pull request, the SolrQueryExecution changes
seem to have issues or need clarification:

   - There are quite a few checks for a column of type timestamp (in
   particular findTimestampIndex) - but it doesn't appear that there is a
   guarantee it will be the correct column. That is you could easily have the
   gap on one field and group by another timestamp column.
   - Why is adjustDateFormat needed now, but wasn't needed before?
   - The this.visitor.isCountStarInUse() logic is only enabled in faceted
   scenario. It looks like "select count(*) from tbl" won't work as expected.

I would like to see unit tests of the execution logic, or perhaps you could
provide a docker image of a representative solr instance to aid in testing.
[image: Add Comment]
<https://issues.jboss.org/browse/TEIID-4572#add-comment> Add Comment
<https://issues.jboss.org/browse/TEIID-4572#add-comment>

This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d)
[image: Atlassian logo]


> Grouping by and faceted search for Solr tranlator
> -------------------------------------------------
>
>                 Key: TEIID-4572
>                 URL: https://issues.jboss.org/browse/TEIID-4572
>             Project: Teiid
>          Issue Type: Enhancement
>          Components: Misc. Connectors
>            Reporter: Hend Amin
>             Fix For: 10.0
>
>
> Currently group by is not supported for Solr translator. For example:
> select x,y, count\(*) from solr_core group by x,y; the corresponding Solr request does not contain group by. 
> Please add group by and faceted search support for Solr translator.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)