[teiid-issues] [JBoss JIRA] (TEIID-5074) Support a way provide SEQUENCE in TeiidDialect

[Steven Hawkins (JIRA)]

    [ https://issues.jboss.org/browse/TEIID-5074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468190#comment-13468190 ] 

Steven Hawkins commented on TEIID-5074:
---------------------------------------

>  I updated the code to return an expression and updated the document to create the function as non-deterministic.

Actually the dialect change that was just committed is incorrect.  The call needs to be nested in parens to be a valid scalar subquery.

Taking a step back, if we could just use a function you'd ideally use a convention like:
{code}
       @Override
	public String getSequenceNextValString(String sequenceName) {
		return "select " + getSelectSequenceNextValString( sequenceName );
	}
 
	@Override
	public String getSelectSequenceNextValString(String sequenceName) {
		return sequenceName + "_nextval()";
	}
{code}

Such that with an import option turned on for oracle/postgresql/etc., we'd automatically create the functions sequence_nextval and sequence_curval.  Note that using the _nextval convention matches the other places in our docs where we mention sequence support.

A small issue is that in the SequenceGenerator annotation it would be best to have the name fully qualified. 

> Support a way provide SEQUENCE in TeiidDialect
> ----------------------------------------------
>
>                 Key: TEIID-5074
>                 URL: https://issues.jboss.org/browse/TEIID-5074
>             Project: Teiid
>          Issue Type: Enhancement
>          Components: JDBC Driver
>            Reporter: Ramesh Reddy
>            Assignee: Ramesh Reddy
>             Fix For: 10.0
>
>
> Currently, the sequence based Table identity generation support is not available in current TeiidDialect. The support will not be direct, but with additional constructs in VDB, we can make this available. Teiid needs to provide a way to call in source specific of way to insert a layer in Teiid to accomplish this.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)