[teiid-issues] [JBoss JIRA] (TEIID-5574) Clarify buffer manager property names

[Ramesh Reddy (Jira)]

    [ https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676074#comment-13676074 ] 

Ramesh Reddy commented on TEIID-5574:
-------------------------------------

> Can you clarify that you currently map the spring config to the EmbeddedConfiguration

I have only exposed one or two properties so far. If user really wants their own configuration in Spring Boot they can simply provide an instance of `EmbeddedConfiguration` as in 

{code}
@Bean
@Primary
EmbeddedConfiguration myconfig() {
   return new EmbeddedConfiguration();
}
{code}

Only in the case they do not provide I take defaults mostly along with spring's approach of what are mostly right values to set?

> but it seems just as easy to just add handling for both and deprecate the old
I do not know any other way than this :(

> Or perhaps skip the cli entirely and let system / env properties supersede?
+1, It may be little confusing for WildFly user, but will avoid whole lot of crud work and work fine in embedded situation. Given my reluctance for WF, I am Ok with it. 

> Clarify buffer manager property names
> -------------------------------------
>
>                 Key: TEIID-5574
>                 URL: https://issues.jboss.org/browse/TEIID-5574
>             Project: Teiid
>          Issue Type: Quality Risk
>          Components: Query Engine, Server
>            Reporter: Steven Hawkins
>            Assignee: Steven Hawkins
>            Priority: Major
>             Fix For: 12.0
>
>
> Where possible the buffer manager properties should be better differentiated.  Instead of max-buffer-space for example, we could have max-buffer-disk-space-mb.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)