[weld-commits] Weld SVN: r5205 - in core/trunk: tests/src/test/java/org/jboss/weld/tests/beanManager and 1 other directories.

[weld-commits at lists.jboss.org]

Author: pete.muir at jboss.org
Date: 2009-12-03 11:12:19 -0500 (Thu, 03 Dec 2009)
New Revision: 5205

Added:
   core/trunk/tests/src/test/java/org/jboss/weld/tests/beanManager/annotation/
   core/trunk/tests/src/test/java/org/jboss/weld/tests/beanManager/annotation/ManagerAnnotationTest.java
Modified:
   core/trunk/impl/src/main/java/org/jboss/weld/metadata/cache/BindingTypeModel.java
Log:
WELD-299

Modified: core/trunk/impl/src/main/java/org/jboss/weld/metadata/cache/BindingTypeModel.java
===================================================================
--- core/trunk/impl/src/main/java/org/jboss/weld/metadata/cache/BindingTypeModel.java	2009-12-03 15:56:38 UTC (rev 5204)
+++ core/trunk/impl/src/main/java/org/jboss/weld/metadata/cache/BindingTypeModel.java	2009-12-03 16:12:19 UTC (rev 5205)
@@ -16,6 +16,8 @@
  */
 package org.jboss.weld.metadata.cache;
 
+import static org.jboss.weld.logging.Category.REFLECTION;
+import static org.jboss.weld.logging.LoggerFactory.loggerFactory;
 import static org.jboss.weld.logging.messages.MetadataMessage.NON_BINDING_MEMBER_TYPE;
 
 import java.lang.annotation.Annotation;
@@ -25,12 +27,12 @@
 import javax.enterprise.util.Nonbinding;
 import javax.inject.Qualifier;
 
-import org.jboss.weld.DefinitionException;
 import org.jboss.weld.WeldException;
 import org.jboss.weld.introspector.WeldMethod;
 import org.jboss.weld.resources.ClassTransformer;
 import org.jboss.weld.util.Reflections;
 import org.jboss.weld.util.collections.Arrays2;
+import org.slf4j.cal10n.LocLogger;
 
 /**
  * 
@@ -41,8 +43,8 @@
  */
 public class BindingTypeModel<T extends Annotation> extends AnnotationModel<T>
 {
+   private static final LocLogger log = loggerFactory().getLogger(REFLECTION);
    
-   
    private static final Set<Class<? extends Annotation>> META_ANNOTATIONS = Arrays2.<Class<? extends Annotation>>asSet(Qualifier.class);
    
    // The non-binding types
@@ -79,7 +81,8 @@
       {
          if ((Reflections.isArrayType(annotatedMethod.getJavaClass()) || Annotation.class.isAssignableFrom(annotatedMethod.getJavaClass())) && !nonBindingTypes.contains(annotatedMethod))
          {
-            throw new DefinitionException(NON_BINDING_MEMBER_TYPE, annotatedMethod);
+            super.valid = false;
+            log.debug(NON_BINDING_MEMBER_TYPE, annotatedMethod);
          }
       }
 

Added: core/trunk/tests/src/test/java/org/jboss/weld/tests/beanManager/annotation/ManagerAnnotationTest.java
===================================================================
--- core/trunk/tests/src/test/java/org/jboss/weld/tests/beanManager/annotation/ManagerAnnotationTest.java	                        (rev 0)
+++ core/trunk/tests/src/test/java/org/jboss/weld/tests/beanManager/annotation/ManagerAnnotationTest.java	2009-12-03 16:12:19 UTC (rev 5205)
@@ -0,0 +1,50 @@
+package org.jboss.weld.tests.beanManager.annotation;
+
+import javax.persistence.PersistenceContext;
+
+import org.jboss.testharness.impl.packaging.Artifact;
+import org.jboss.weld.test.AbstractWeldTest;
+import org.testng.annotations.Test;
+
+ at Artifact
+public class ManagerAnnotationTest extends AbstractWeldTest
+{
+   
+   @Test
+   public void testIsQualifier() throws Exception
+   {
+      assert !getCurrentManager().isQualifier(PersistenceContext.class);
+   }
+   
+   @Test
+   public void testIsInterceptorBinding() throws Exception
+   {
+      assert !getCurrentManager().isInterceptorBinding(PersistenceContext.class);
+   }
+   
+   @Test
+   public void testIsNormalScope() throws Exception
+   {
+      assert !getCurrentManager().isNormalScope(PersistenceContext.class);
+   }
+   
+   @Test
+   public void testIsPassivatingScope() throws Exception
+   {
+      assert !getCurrentManager().isPassivatingScope(PersistenceContext.class);
+   }
+   
+   @Test
+   public void testIsScope() throws Exception
+   {
+      assert !getCurrentManager().isScope(PersistenceContext.class);
+   }
+   
+   @Test
+   public void testIsStereotype() throws Exception
+   {
+      assert !getCurrentManager().isStereotype(PersistenceContext.class);
+   }
+   
+   
+}


Property changes on: core/trunk/tests/src/test/java/org/jboss/weld/tests/beanManager/annotation/ManagerAnnotationTest.java
___________________________________________________________________
Name: svn:mime-type
   + text/plain
Name: svn:eol-style
   + native