[webbeans-commits] Webbeans SVN: r3218 - tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/request/ejb and 5 other directories.
webbeans-commits at lists.jboss.org
webbeans-commits at lists.jboss.org
Sat Jul 25 12:51:39 EDT 2009
Author: pete.muir at jboss.org
Date: 2009-07-25 12:51:39 -0400 (Sat, 25 Jul 2009)
New Revision: 3218
Modified:
ri/trunk/impl/src/main/java/org/jboss/webbeans/FacadeImpl.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/request/ejb/EJBRequestContextTest.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanDiscoveryObserver/AfterBeanDiscoveryObserverExecutionFailureTest.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanValidationObserver/AfterDeploymentValidationObserverExecutionFailureTest.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/passivatingScope/AddingPassivatingScopeTest.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/useBeforeValidationFails/UseBeforeValidationTest.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/implicit/ImplicitEventTest.java
Log:
Fix RI serialization problem, mark some tests broken due to missing Extension stuff, add notes on why RI is broken
Modified: ri/trunk/impl/src/main/java/org/jboss/webbeans/FacadeImpl.java
===================================================================
--- ri/trunk/impl/src/main/java/org/jboss/webbeans/FacadeImpl.java 2009-07-25 15:45:57 UTC (rev 3217)
+++ ri/trunk/impl/src/main/java/org/jboss/webbeans/FacadeImpl.java 2009-07-25 16:51:39 UTC (rev 3218)
@@ -56,7 +56,9 @@
{
this.manager = manager;
this.type = type;
- this.bindings = bindings;
+ // Need to make sure the Set is serializable, some sets from Google Collections aren't
+ // TODO Work out how to not do this
+ this.bindings = new HashSet<Annotation>(bindings);
}
/**
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/request/ejb/EJBRequestContextTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/request/ejb/EJBRequestContextTest.java 2009-07-25 15:45:57 UTC (rev 3217)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/request/ejb/EJBRequestContextTest.java 2009-07-25 16:51:39 UTC (rev 3218)
@@ -25,6 +25,7 @@
* bean, during any call to an EJB timeout method and during message delivery
* to any EJB message driven bean.
*/
+ // WBRI-301
@Test(groups = { "ri-broken", "contexts", "ejb3.1", "integration" })
@SpecAssertion(section = "6.7.1", id = "gc")
public void testRequestScopeActiveDuringCallToEjbTimeoutMethod() throws Exception
@@ -39,6 +40,7 @@
* The request context is destroyed after the remote method invocation,
* timeout or message delivery completes.
*/
+ // WBRI-301
@Test(groups = { "ri-broken", "contexts", "ejb3.1", "integration" })
@SpecAssertion(section = "6.7.1", id = "hc")
public void testRequestScopeDestroyedAfterCallToEjbTimeoutMethod() throws Exception
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanDiscoveryObserver/AfterBeanDiscoveryObserverExecutionFailureTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanDiscoveryObserver/AfterBeanDiscoveryObserverExecutionFailureTest.java 2009-07-25 15:45:57 UTC (rev 3217)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanDiscoveryObserver/AfterBeanDiscoveryObserverExecutionFailureTest.java 2009-07-25 16:51:39 UTC (rev 3218)
@@ -20,7 +20,9 @@
@ExpectedDeploymentException(DefinitionError.class)
public class AfterBeanDiscoveryObserverExecutionFailureTest extends AbstractJSR299Test
{
- @Test(groups="incontainer-ri-broken")
+ @Test(groups={"incontainer-ri-broken", "broken"})
+ //TODO Needs Extension stuff adding
+ // Not working, needs JBAS-7047
@SpecAssertion(section = "11.5.2", id = "d")
public void testObserverFailureTreatedAsDefinitionError()
{
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanValidationObserver/AfterDeploymentValidationObserverExecutionFailureTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanValidationObserver/AfterDeploymentValidationObserverExecutionFailureTest.java 2009-07-25 15:45:57 UTC (rev 3217)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanValidationObserver/AfterDeploymentValidationObserverExecutionFailureTest.java 2009-07-25 16:51:39 UTC (rev 3218)
@@ -37,7 +37,9 @@
@ExpectedDeploymentException(DeploymentError.class)
public class AfterDeploymentValidationObserverExecutionFailureTest extends AbstractJSR299Test
{
- @Test(groups="incontainer-ri-broken")
+ @Test(groups={"incontainer-ri-broken", "broken"})
+ // TODO Needs Extension stuff adding
+ // Not working, needs JBAS-7047
@SpecAssertion(section = "11.5.3", id = "c")
public void testObserverFailureTreatedAsDeploymentError()
{
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/passivatingScope/AddingPassivatingScopeTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/passivatingScope/AddingPassivatingScopeTest.java 2009-07-25 15:45:57 UTC (rev 3217)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/passivatingScope/AddingPassivatingScopeTest.java 2009-07-25 16:51:39 UTC (rev 3218)
@@ -41,6 +41,7 @@
{
@Test(groups="ri-broken")
+ // Not working, needs JBAS-7047
@SpecAssertion(section="11.5.1", id="ac")
public void testAddingScopeType()
{
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/useBeforeValidationFails/UseBeforeValidationTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/useBeforeValidationFails/UseBeforeValidationTest.java 2009-07-25 15:45:57 UTC (rev 3217)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/useBeforeValidationFails/UseBeforeValidationTest.java 2009-07-25 16:51:39 UTC (rev 3218)
@@ -33,8 +33,10 @@
@Artifact
public class UseBeforeValidationTest extends AbstractJSR299Test
{
- @Test(groups = "ri-broken")
+ @Test(groups = {"ri-broken", "broken"})
//Still not clear how the container should now allow this, but the RI is clearly not implementing this assertion
+ // TODO Needs Extension stuff adding
+ // WBRI-300
@SpecAssertions({
@SpecAssertion(section = "11.5.3", id = "d")
})
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/implicit/ImplicitEventTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/implicit/ImplicitEventTest.java 2009-07-25 15:45:57 UTC (rev 3217)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/implicit/ImplicitEventTest.java 2009-07-25 16:51:39 UTC (rev 3218)
@@ -85,10 +85,10 @@
assert directory.getStudents().contains(student);
}
- @Test(groups = { "ri-broken", "events" })
+ @Test(groups = { "events" })
@SpecAssertions({
@SpecAssertion(section = "10.3.2", id = "g"),
- @SpecAssertion(section = "6.6.2", id = "e") // break up this assertion into smaller bits
+ @SpecAssertion(section = "6.6.2", id = "e") // TODO break up this assertion into smaller bits
})
public void testImplicitEventIsPassivationCapable() throws IOException, ClassNotFoundException
{
More information about the weld-commits
mailing list