[webbeans-commits] Webbeans SVN: r3662 - in tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests: context/dependent and 14 other directories.
webbeans-commits at lists.jboss.org
webbeans-commits at lists.jboss.org
Mon Sep 14 13:55:44 EDT 2009
Author: pete.muir at jboss.org
Date: 2009-09-14 13:55:44 -0400 (Mon, 14 Sep 2009)
New Revision: 3662
Modified:
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/conversation/client/AbstractConversationTest.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/dependent/InteriorRoom.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/UnderwaterCity.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingBeanConstructor/UnderwaterCity.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingInitializerMethod/UnderwaterCity.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingInjectedField/UnderwaterCity.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/DataAccessImpl.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/NotAuthorizedException.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanDiscoveryObserver/FooException.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/useBeforeValidationFails/UseBeforeValidationTest.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/implementation/builtin/MockLoginModule.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/implementation/simple/lifecycle/Cod.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/inheritance/specialization/producer/method/broken/twoBeansSpecializeTheSameBean/PictureShop_Broken.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/clientProxy/ClientProxyTest.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/dynamic/builtin/BuiltinInstanceTest.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injectionpoint/broken/reference/ambiguous/AnnotatedInjectionField.java
tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injectionpoint/broken/reference/unresolved/AnnotatedInjectionField.java
Log:
cleanup todos
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/conversation/client/AbstractConversationTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/conversation/client/AbstractConversationTest.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/conversation/client/AbstractConversationTest.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -12,7 +12,7 @@
public abstract class AbstractConversationTest extends AbstractJSR299Test
{
- // TODO this should be part of the JSR-299 API
+
public static final String CID_REQUEST_PARAMETER_NAME = "cid";
public static final String CID_HEADER_NAME = "org.jboss.jsr299.tck.cid";
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/dependent/InteriorRoom.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/dependent/InteriorRoom.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/dependent/InteriorRoom.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -5,7 +5,6 @@
{
public void foo()
{
- // TODO Auto-generated method stub
}
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/UnderwaterCity.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/UnderwaterCity.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/UnderwaterCity.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -5,7 +5,6 @@
public void foo()
{
- // TODO Auto-generated method stub
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingBeanConstructor/UnderwaterCity.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingBeanConstructor/UnderwaterCity.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingBeanConstructor/UnderwaterCity.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -7,7 +7,6 @@
public void foo()
{
- // TODO Auto-generated method stub
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingInitializerMethod/UnderwaterCity.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingInitializerMethod/UnderwaterCity.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingInitializerMethod/UnderwaterCity.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -10,7 +10,6 @@
public void foo()
{
- // TODO Auto-generated method stub
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingInjectedField/UnderwaterCity.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingInjectedField/UnderwaterCity.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/broken/decoratorWithNonPassivatingInjectedField/UnderwaterCity.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -7,7 +7,6 @@
public void foo()
{
- // TODO Auto-generated method stub
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/DataAccessImpl.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/DataAccessImpl.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/DataAccessImpl.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -23,49 +23,29 @@
public class DataAccessImpl implements DataAccess
{
- /* (non-Javadoc)
- * @see org.jboss.jsr299.tck.tests.deployment.lifecycle.DataAccess#delete()
- */
public void delete()
{
- // TODO Auto-generated method stub
}
- /* (non-Javadoc)
- * @see org.jboss.jsr299.tck.tests.deployment.lifecycle.DataAccess#getDataType()
- */
public Class<?> getDataType()
{
- // TODO Auto-generated method stub
return null;
}
- /* (non-Javadoc)
- * @see org.jboss.jsr299.tck.tests.deployment.lifecycle.DataAccess#getId()
- */
public Object getId()
{
- // TODO Auto-generated method stub
return null;
}
- /* (non-Javadoc)
- * @see org.jboss.jsr299.tck.tests.deployment.lifecycle.DataAccess#load(java.lang.Object)
- */
public Object load(Object id)
{
- // TODO Auto-generated method stub
return null;
}
- /* (non-Javadoc)
- * @see org.jboss.jsr299.tck.tests.deployment.lifecycle.DataAccess#save()
- */
public void save()
{
- // TODO Auto-generated method stub
-
+
}
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/NotAuthorizedException.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/NotAuthorizedException.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/NotAuthorizedException.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -7,13 +7,11 @@
public NotAuthorizedException(String message, Throwable cause)
{
super(message, cause);
- // TODO Auto-generated constructor stub
}
public NotAuthorizedException(String message)
{
super(message);
- // TODO Auto-generated constructor stub
}
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanDiscoveryObserver/FooException.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanDiscoveryObserver/FooException.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/exceptionInAfterBeanDiscoveryObserver/FooException.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -28,28 +28,24 @@
*/
private static final long serialVersionUID = 4441409975741605270L;
-public FooException()
+ public FooException()
{
super();
- // TODO Auto-generated constructor stub
}
public FooException(String arg0, Throwable arg1)
{
super(arg0, arg1);
- // TODO Auto-generated constructor stub
}
public FooException(String arg0)
{
super(arg0);
- // TODO Auto-generated constructor stub
}
public FooException(Throwable arg0)
{
super(arg0);
- // TODO Auto-generated constructor stub
}
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/useBeforeValidationFails/UseBeforeValidationTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/useBeforeValidationFails/UseBeforeValidationTest.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/deployment/lifecycle/broken/useBeforeValidationFails/UseBeforeValidationTest.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -38,7 +38,7 @@
@Test(groups = {"ri-broken", "rewrite"})
//Still not clear how the container should now allow this, but the RI is clearly not implementing this assertion
// TODO Needs Extension stuff adding
- // TODO This isn't what this assertion means, it really means external requests, very hard to test
+ // TODO very hard to test
// WBRI-300
@SpecAssertions({
@SpecAssertion(section = "11.5.3", id = "d"),
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/implementation/builtin/MockLoginModule.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/implementation/builtin/MockLoginModule.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/implementation/builtin/MockLoginModule.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -37,7 +37,6 @@
public MockLoginModule()
{
- // TODO Auto-generated constructor stub
}
public boolean abort() throws LoginException
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/implementation/simple/lifecycle/Cod.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/implementation/simple/lifecycle/Cod.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/implementation/simple/lifecycle/Cod.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -14,7 +14,6 @@
public void ping()
{
- // TODO Auto-generated method stub
}
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/inheritance/specialization/producer/method/broken/twoBeansSpecializeTheSameBean/PictureShop_Broken.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/inheritance/specialization/producer/method/broken/twoBeansSpecializeTheSameBean/PictureShop_Broken.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/inheritance/specialization/producer/method/broken/twoBeansSpecializeTheSameBean/PictureShop_Broken.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -8,7 +8,6 @@
@Override @Produces @Specializes
public Product getExpensiveGift()
{
- // TODO Auto-generated method stub
return super.getExpensiveGift();
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/clientProxy/ClientProxyTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/clientProxy/ClientProxyTest.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/clientProxy/ClientProxyTest.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -81,7 +81,7 @@
assert false;
}
- // TODO need to set request scope active again, some other tests will fail otherwise
+ // need to set request scope active again, some other tests will fail otherwise
setContextActive(getCurrentConfiguration().getContexts().getRequestContext());
}
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/dynamic/builtin/BuiltinInstanceTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/dynamic/builtin/BuiltinInstanceTest.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/dynamic/builtin/BuiltinInstanceTest.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -37,14 +37,16 @@
@Test
@SpecAssertion(section = "5.7.2", id = "d")
- public void testScopeOfBuiltinInstance() {
+ public void testScopeOfBuiltinInstance()
+ {
Bean<Instance<Cow>> bean = getBeans(new TypeLiteral<Instance<Cow>>() {}).iterator().next();
assert Dependent.class.equals(bean.getScope());
}
@Test
@SpecAssertion(section = "5.7.2", id = "e")
- public void testNameOfBuiltinInstance() {
+ public void testNameOfBuiltinInstance()
+ {
Bean<Instance<Cow>> bean = getBeans(new TypeLiteral<Instance<Cow>>() {}).iterator().next();
assert bean.getName() == null;
}
@@ -52,18 +54,20 @@
@Test
@SpecAssertions({
@SpecAssertion(section = "5.7.2", id = "a"),
- @SpecAssertion(section = "5.7.2", id = "f")})
- public void testInstanceProvidedForEveryLegalBeanType() {
+ @SpecAssertion(section = "5.7.2", id = "f")
+ })
+ public void testInstanceProvidedForEveryLegalBeanType()
+ {
Farm farm = getInstanceByType(Farm.class);
assert farm.getAnimal() != null;
assert farm.getAbstractAnimal() != null;
assert farm.getCow() != null;
}
- @Test
+ @Test(groups = "broken")
@SpecAssertion(section = "5.7.2", id = "g")
public void testInstanceIsPassivationCapable() {
Bean<Instance> instance = getBeans(Instance.class).iterator().next();
- // TODO assert instance.isSerializable();
+ // assert instance.isSerializable();
}
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injectionpoint/broken/reference/ambiguous/AnnotatedInjectionField.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injectionpoint/broken/reference/ambiguous/AnnotatedInjectionField.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injectionpoint/broken/reference/ambiguous/AnnotatedInjectionField.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -33,7 +33,6 @@
public AnnotatedType<InjectedBean> getDeclaringType()
{
- // TODO Auto-generated method stub
return null;
}
@@ -44,31 +43,26 @@
public <T extends Annotation> T getAnnotation(Class<T> annotationType)
{
- // TODO Auto-generated method stub
return null;
}
public Set<Annotation> getAnnotations()
{
- // TODO Auto-generated method stub
return null;
}
public Type getBaseType()
{
- // TODO Auto-generated method stub
return InjectedBean.class;
}
public Set<Type> getTypeClosure()
{
- // TODO Auto-generated method stub
return null;
}
public boolean isAnnotationPresent(Class<? extends Annotation> annotationType)
{
- // TODO Auto-generated method stub
return false;
}
Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injectionpoint/broken/reference/unresolved/AnnotatedInjectionField.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injectionpoint/broken/reference/unresolved/AnnotatedInjectionField.java 2009-09-14 15:46:43 UTC (rev 3661)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injectionpoint/broken/reference/unresolved/AnnotatedInjectionField.java 2009-09-14 17:55:44 UTC (rev 3662)
@@ -33,7 +33,6 @@
public AnnotatedType<InjectedBean> getDeclaringType()
{
- // TODO Auto-generated method stub
return null;
}
@@ -44,31 +43,26 @@
public <T extends Annotation> T getAnnotation(Class<T> annotationType)
{
- // TODO Auto-generated method stub
return null;
}
public Set<Annotation> getAnnotations()
{
- // TODO Auto-generated method stub
return null;
}
public Type getBaseType()
{
- // TODO Auto-generated method stub
return InjectedBean.class;
}
public Set<Type> getTypeClosure()
{
- // TODO Auto-generated method stub
return null;
}
public boolean isAnnotationPresent(Class<? extends Annotation> annotationType)
{
- // TODO Auto-generated method stub
return false;
}
More information about the weld-commits
mailing list