[weld-commits] [weld/core] e2425c: Revert "WELD-1802 destroying conversation if an ex...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/weld/core
  Commit: e2425cb13605d69646cd468fc7962b284e41cf7b
      https://github.com/weld/core/commit/e2425cb13605d69646cd468fc7962b284e41cf7b
  Author: Martin Kouba <mkouba at redhat.com>
  Date:   2014-12-01 (Mon, 01 Dec 2014)

  Changed paths:
    M impl/src/main/java/org/jboss/weld/context/AbstractConversationContext.java
    M impl/src/main/java/org/jboss/weld/logging/ContextLogger.java

  Log Message:
  -----------
  Revert "WELD-1802 destroying conversation if an exception occurs when attaching bean store"

This reverts commit 311dd7916304b6275a4790bb77b8cccd6694c068.

The destruction of the conversation is not necessary. If an HTTP session times out all the conversations are destroyed automatically (in a seperate thread). Moreover the fix for WELD-1774 prevents from using leaked associated HTTP requests.


  Commit: b752cc0fe5959d936b003050a2d4d2e88f272916
      https://github.com/weld/core/commit/b752cc0fe5959d936b003050a2d4d2e88f272916
  Author: Martin Kouba <mkouba at redhat.com>
  Date:   2014-12-01 (Mon, 01 Dec 2014)

  Changed paths:
    A tests-arquillian/src/test/java/org/jboss/weld/tests/contexts/conversation/sessiontimeout/ConversationContextDestroyedOnSessionTimeoutTest.java
    A tests-arquillian/src/test/java/org/jboss/weld/tests/contexts/conversation/sessiontimeout/Foo.java
    A tests-arquillian/src/test/java/org/jboss/weld/tests/contexts/conversation/sessiontimeout/SessionListener.java
    A tests-arquillian/src/test/java/org/jboss/weld/tests/contexts/conversation/sessiontimeout/TestServlet.java

  Log Message:
  -----------
  WELD-1802 Adding test to simulate the leaking scenario


Compare: https://github.com/weld/core/compare/11d91b9b7bf5...b752cc0fe595