[weld-dev] examples build.xml updated.

[Dan Allen]

Steven,

I see that you set jboss.home to ${env.JBOSS_HOME} in build.xml, but why not
do this in build.properties? The reason I suggest that is because having the
following in build.properties is just misleading and cruft (it's what has
always been there, so I'm not implying you added it)

jboss.home=/Applications/jboss-5.2.0.Beta1
tomcat.home=/Applications/apache-tomcat-6.0.20

Better is for build.xml to simply read build.properties as defined here:

jboss.home=${env.JBOSS_HOME}
tomcat.home=${env.CATALINA_HOME}

Here are the lines you need in build.xml

   <property environment="env"/><!-- assign OS environment variables to an
object visible to ANT -->

   <!-- preserve local build.properties if they're still being used -->
   <property file="${wbexamples.dir}/../jboss-as/local.build.properties" />
   <property file="${wbexamples.dir}/local.build.properties" />

   <property file="${wbexamples.dir}/../jboss-as/build.properties" />
   <property file="${wbexamples.dir}/build.properties" />

They can either setup jboss.home in the jboss-as directory or the root of
the examples directory. It first uses local.build.properties overrides (for
developers that do have multiple instances of JBoss AS that don't coincide
w/ JBOSS_HOME), then we check build.properties, which should be as above.

-Dan

On Wed, Dec 9, 2009 at 3:35 PM, Steven Boscarine <
steven.boscarine at childrens.harvard.edu> wrote:

> On 12/09/2009 06:18 AM, Pete Muir wrote:
>
>>
>> Right, we have local.build.properties for this.
>>
>> But this is a good change overall, if you want to change it, that would be
>> great :-) (affected are examples and TCK runs I think)
>>
>
> I made the change and left the local.build.properties reference, so no one
> will need to change their configs as long as they're not using the main
> build.properties file.  Examples appear to work fine.  The new build should
> work identically to the old one.
>
> How do I confirm this hasn't affected the TCK?
>
> Also, what do I have to do beyond confirm
> http://www.seamframework.org/Documentation/RunningWeldExamplesWithJBossApplicationServer6works w/ JBOSS_HOME to test the change?
>
> Thanks,
> Steven
>



-- 
Dan Allen
Senior Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597

http://mojavelinux.com
http://mojavelinux.com/seaminaction
http://www.google.com/profiles/dan.j.allen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20091209/3c02b1b8/attachment.html