[weld-dev] wrong msg numbers in ConversationMessage

[Pete Muir]

I would personally only fix the conflicts and just put a note that the sequencing went wrong somewhere in both files, and then live with it. The only reason for the contiguous blocks of numbers was to prevent conflicts.

On 8 Mar 2011, at 14:05, Ales Justin wrote:

> Any particular reason why ConversationMessage has 2xx numbers,
> where it should only have 3xx, while ContextMessage is the right 2xx owner?
> 
> Also, 214 actually overlaps with ContextMessage' 214.
> 
> I guess we can fix this for v1.2.
> And we just make sure we know which Weld version is used when dealing with the msg numbers.
> 
> -Ales
> 
> ---
> 
> /**
> * Log messages for conversations
> * 
> * Message Ids: 000300 - 000399
> * 
> */
> public enum ConversationMessage
> {
> 
>   @MessageId("000300") NO_CONVERSATION_TO_RESTORE,
>   @MessageId("000301") UNABLE_TO_RESTORE_CONVERSATION,
>   @MessageId("000302") CONVERSATION_LOCK_UNAVAILABLE,
>   @MessageId("000303") CONVERSATION_SWITCHED,
>   @MessageId("000304") CLEANING_UP_CONVERSATION,
>   @MessageId("000305") CONVERSATION_TERMINATION_SCHEDULED,
>   @MessageId("000306") CONVERSATION_TERMINATION_CANCELLED,
>   @MessageId("000307") CONVERSATION_TERMINATION_CANCELLATION_FAILED,
>   @MessageId("000308") DESTROY_LRC_COMPLETE,
>   @MessageId("000309") LRC_COUNT,
>   @MessageId("000310") DESTROY_TRANSIENT_COVERSATION,
>   @MessageId("000311") DESTROY_LRC,
>   @MessageId("000312") DESTROY_ALL_LRC,
>   @MessageId("000313") CONVERSATION_LOCKED,
>   @MessageId("000314") CONVERSATION_UNLOCKED,
>   @MessageId("000315") CONVERSATION_UNAVAILBLE,
>   @MessageId("000316") ILLEGAL_CONVERSATION_UNLOCK_ATTEMPT,
>   @MessageId("000317") PROMOTED_TRANSIENT,
>   @MessageId("000318") DEMOTED_LRC,
>   @MessageId("000319") SWITCHED_CONVERSATION,
> 
> ---> HERE
> 
>   @MessageId("000214") BEGIN_CALLED_ON_LONG_RUNNING_CONVERSATION,
>   @MessageId("000215") END_CALLED_ON_TRANSIENT_CONVERSATION,
>   @MessageId("000216") NULL_HTTP_SESSION,
>   @MessageId("000217") SWITCHING_MODE_RESETS_TIMEOUTS,
>   @MessageId("000218") CONVERSATION_ID_ALREADY_IN_USE,
> 
> 
> _______________________________________________
> weld-dev mailing list
> weld-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/weld-dev