[webbeans-issues] [JBoss JIRA] Commented: (WBRI-32) AbstractComponentModel more ellegant

[Pete Muir (JIRA)]

    [ https://jira.jboss.org/jira/browse/WBRI-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12423865#action_12423865 ] 

Pete Muir commented on WBRI-32:
-------------------------------

You can't just alter a spec based API based on what you think is semantically correct.

Whilst you did extract some logic, you also broke DRY and made another test fail above WBRI-33.

Your help with WBRI is appreciated, but you are working in totally the wrong area here (as it is WIP).

Take a look at some outlying feature - https://jira.jboss.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310650&customfield_12310143=community_contributor_needed

> AbstractComponentModel more ellegant
> ------------------------------------
>
>                 Key: WBRI-32
>                 URL: https://jira.jboss.org/jira/browse/WBRI-32
>             Project: Web Beans RI
>          Issue Type: Patch
>    Affects Versions: 1.0.0.EDR2
>            Reporter: Diego Coronel
>            Assignee: Pete Muir
>            Priority: Optional
>         Attachments: abstractComponentModelPatch.patch
>
>
> Some codes in this class are replicated, i just did a small refactor to make it more reusable. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira