[weld-issues] [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces

[Pete Muir (JIRA)]

    [ https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12495944#action_12495944 ] 

Pete Muir commented on WELD-301:
--------------------------------

Yeah, when *we* do class hierarchy analysis we iterate up the class hierarchy, discovering interfaces along the way. However in this case the discovery is done by the GlassFish / Weld integration code (in the EJB portion) and transported to Weld via GlassFish's implementation of EjbDescriptor, provided to the container by the relevant BeanDeploymentArchive. 

If you take a look at SessionBean.initTypes() (which populates sessionBean.getTypes()), you can see that we simple iterate over all local business interfaces from the EjbDescriptor, and collect them. So I would assume GlassFish is only providing LightYellowPearTreeLocal as a business interface, and not PearTreeLocal.

> ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WELD-301
>                 URL: https://jira.jboss.org/jira/browse/WELD-301
>             Project: Weld
>          Issue Type: Bug
>    Affects Versions: 1.0.0.GA
>         Environment: X86/Ubuntu
>            Reporter: Hong Zhang
>            Priority: Critical
>
> I am investigating the deployment failure when running org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
> The deployment failed due to some validation failure in weld RI code. It complains that produceLightYellowPear method of LightYellowPearTree is not declared in LightYellowPearTree business interface. But LightYellowTree implements LightYellowPearTreeLocal which extends from PearTreeLocal which delares the produceLightYellowPear method.
> This seems a weld RI bug to me after stepping into the RI code:
> In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for its implemented interface and super class for whether they declared this business method. But the problem is it only goes to its direct implemented interface and not the interface hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does declare this method. The RI code should be modified to check for the whole interface hierarchy and not just the direct implemented interface.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira