[weld-issues] [JBoss JIRA] Commented: (WELDX-23) Support servlet injection on Jetty

Matija Mazi (JIRA) jira-events at lists.jboss.org
Mon Feb 22 11:47:10 EST 2010


    [ https://jira.jboss.org/jira/browse/WELDX-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12515772#action_12515772 ] 

Matija Mazi commented on WELDX-23:
----------------------------------

The TCCL swap remained from early testing when it seemed necessary, but now I see it's redundant so I'll remove it. (Should I submit a new patch?)

WeldInjection's superclass Injection is ment to represent an injection into a single field or setter method (an "injection point"). So for example, if there is a bean with three injection points, Jetty expects three Injection instances to be created, but instead we only create a single WeldInjection that takes care of it all. That is much easier to implement; otherwise we'd have to duplicate some logic that's already done by Weld, or do some more serious hacking into Jetty.

The logic that determines which Injections will be used at all resides outside Injection (in InjectionCollection.add(..)); it checks whether the Injection seems valid. In order for WeldInjection to seem valid, it's enough to make sure that WeldInjection.getTarget() doesn't return null. It now returns the bean's toString() method that's always there.


> Support servlet injection on Jetty
> ----------------------------------
>
>                 Key: WELDX-23
>                 URL: https://jira.jboss.org/jira/browse/WELDX-23
>             Project: Weld Extensions
>          Issue Type: Feature Request
>          Components: Servlet Containers
>            Reporter: Pete Muir
>            Assignee: Matija Mazi
>         Attachments: jetty-injection.patch, myapp-context.xml
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the weld-issues mailing list