[weld-issues] [JBoss JIRA] Commented: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality

Pete Muir (JIRA) jira-events at lists.jboss.org
Sun Jan 31 11:58:19 EST 2010


    [ https://jira.jboss.org/jira/browse/WELD-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12509452#action_12509452 ] 

Pete Muir commented on WELD-409:
--------------------------------

Why not alter producerMethodBeanMap itself, so that it's key is unique? Then you can construct the key inside getProducerMethod, and keep the speed of this being a hashmap lookup. With this change, please apply.

Otherwise, good work, and I am very glad to see that this assumption didn't pervade too deep :-)

> Remove custom equality for AnnotatedType and rely on cache/object equality
> --------------------------------------------------------------------------
>
>                 Key: WELD-409
>                 URL: https://jira.jboss.org/jira/browse/WELD-409
>             Project: Weld
>          Issue Type: Bug
>          Components: Reflection layer
>            Reporter: Pete Muir
>            Assignee: Stuart Douglas
>             Fix For: 1.0.1.CR2
>
>         Attachments: remove-equality-1.diff
>
>
> Currently we use the underlying class to perform equality, this is wrong.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the weld-issues mailing list