[weld-issues] [JBoss JIRA] Commented: (CDITCK-186) TCK does not properly test for inhertance of observer methods

Tue Nov 2 02:10:59 EDT 2010

    [ https://jira.jboss.org/browse/CDITCK-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560721#action_12560721 ] 

Marius Bogoevici commented on CDITCK-186:
-----------------------------------------

The test is still wrong. In order for the test to be complete, LazyFarmer and IndirectStockWatcher must implement the respective observer interfaces, otherwise the observer methods are not part of the EJBs business interface (see EJB 3.1 spec 4.9.2.1 and https://jira.jboss.org/browse/WELD-746).

> TCK does not properly test for inhertance of observer methods
> -------------------------------------------------------------
>
>                 Key: CDITCK-186
>                 URL: https://jira.jboss.org/browse/CDITCK-186
>             Project: CDI TCK
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>            Reporter: Igor Vaynberg
>             Fix For: 1.0.2.CR3
>
>
> EventTest has a bug in it. According to section 4.2 of the spec
> {code}
> If X declares an initializer, non-static observer, @PostConstruct or @PreDestroy method x() then
> Y inherits x() if and only if neither Y nor any intermediate class that is a subclass of X and a
> superclass of Y overrides the method x().
> {code}
> both IntermediateStockWatcher and IndirectStockWatcher which extend StockWatcher should inherit its observer method:
> {code}
> StockWatcher#public void observeStockPrice(@Observes StockPrice price)
> {code}
> However, EventTest on line 149 asserts there is only one observer method, when in fact there should be three:
> {code}
> 147: StockPrice price = new StockPrice();
> 148: Set<ObserverMethod<? super StockPrice>> observers = getCurrentManager().resolveObserverMethods(price);
> 149: assert observers.size() == 1;
> {code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira