[weld-issues] [JBoss JIRA] Commented: (CDI-17) Change name of the @Observes Reception attribute to "notified"

Pete Muir (JIRA) jira-events at lists.jboss.org
Wed Oct 27 04:51:57 EDT 2010


    [ https://jira.jboss.org/browse/CDI-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559614#action_12559614 ] 

Pete Muir commented on CDI-17:
------------------------------

We will be switching back to notifyObserver for the next release. Fixing the java api to match the spec will be considered as part of the CDI MR.

> Change name of the @Observes Reception attribute to "notified"
> --------------------------------------------------------------
>
>                 Key: CDI-17
>                 URL: https://jira.jboss.org/browse/CDI-17
>             Project: CDI Specification Issues
>          Issue Type: Feature Request
>          Components: Javadoc and API
>    Affects Versions: 1.0
>            Reporter: Dan Allen
>            Priority: Minor
>             Fix For: 1.1
>
>
> As of the CDI 1.0 specification, the name of the Reception attribute on @Observes is "receive". The patch release of the API (SP1) changes the name to "notifyObserver", so a change is already being considered. Therefore, I'd like to suggest a better name that would read more fluently. That name is "notified".
> Let us compare the three cases:
> 1. @Observes(receive = IF_EXISTS)
> 2. @Observes(notifyObserver = IF_EXISTS)
> 3. @Observes(notified = IF_EXISTS)
> Of the three, notifyObserver breaks the flow of the sentence the most. On the other hand, notified reads nicely, including with the TransactionPhase attribute included:
> @Observes(notified = IF_EXISTS, during = TransactionPhase.AFTER_SUCCESS)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the weld-issues mailing list