[weld-issues] [JBoss JIRA] Commented: (WELD-674) Weld Tomcat 7.0.x support

[Pete Muir (JIRA)]

    [ https://jira.jboss.org/browse/WELD-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12552024#action_12552024 ] 

Pete Muir commented on WELD-674:
--------------------------------

I have reviewed your changes, and made some subsequent fixes.

In the future please make an attempt to make your changes tidier. Specifically, your whitespace was way outside of guidelines (http://seamframework.org/Weld/GuidelinesForWeldDevelopment), none of the javadoc was updated, the exception messages referred to the code you had copied, not your new code. Also, you may want to look at merging commits in git to produce a tidier change log.

Otherwise, looks good. I've pushed your changes despite lack of tests, as this is new area for us -- if you have some time maybe you could look at WELD-691 and add a new module which can run the tests in Tomcat 7?

Thanks again!

> Weld Tomcat 7.0.x support
> -------------------------
>
>                 Key: WELD-674
>                 URL: https://jira.jboss.org/browse/WELD-674
>             Project: Weld
>          Issue Type: Feature Request
>          Components: Servlet Container Support
>    Affects Versions: 1.1.0.Beta1
>         Environment: Tomcat 7.0.x
>            Reporter: Davide Malpassini
>             Fix For: 1.1.0.Beta2
>
>         Attachments: ForwardingInstanceManager.java, WeldForwardingInstanceManager.java, WeldInstanceManager.java
>
>
> Tomcat 7 have dropped the AnnotationProcessor and in the latest version uses Instance Manager. So Weld can't bootstrap.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira