[weld-issues] [JBoss JIRA] Commented: (WELD-913) SeamApplicationWrapper doesn't implement setApplication() correctly

Christian Kaltepoth (JIRA) jira-events at lists.jboss.org
Wed Jun 8 11:32:59 EDT 2011


    [ https://issues.jboss.org/browse/WELD-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607209#comment-12607209 ] 

Christian Kaltepoth commented on WELD-913:
------------------------------------------

Exactly!

Currently {{WeldApplicationFactory}} lazily creates a wrapped {{Application}} in {{getApplication()}} and save a reference to this wrapped instance for further calls to {{getApplication()}. Calls to {{setApplication()}} are simply forwarded to the underlying factory (by {{ForwardingApplicationFactory}}). So further calls to {{getApplication()}} will return the old {{Application}} instances created in the first call which is not correct according to the spec.

You can find a few more comment on this in SEAMFACES-165.

> SeamApplicationWrapper doesn't implement setApplication() correctly
> -------------------------------------------------------------------
>
>                 Key: WELD-913
>                 URL: https://issues.jboss.org/browse/WELD-913
>             Project: Weld
>          Issue Type: Bug
>          Components: Web Tier integration (JSF, JSP, EL and Servlet) 
>    Affects Versions: 1.1.0.Final
>         Environment: Tomcat 7.0.8, Seam Faces 3.0.1, MyFaces 2.0.5
>            Reporter: Christian Kaltepoth
>            Assignee: Shane Bryzak
>             Fix For: 1.1.2.Final
>
>
> While debugging SEAMFACES-165 I discovered that {{WeldApplicationFactory}} doesn't implement {{setApplication()}} correctly. The class should recreate the locally cached {{Application}} so that future calls to {{getApplication()}} return a correctly wrapped version of the new {{Application}} instance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the weld-issues mailing list