[weld-issues] [JBoss JIRA] (WELD-954) URIs escaped twice in URLScanner

[Ales Justin (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/WELD-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638300#comment-12638300 ] 

Ales Justin commented on WELD-954:
----------------------------------

URL::openStream has nothing to do with scanning -- see URLScanner; the actual class loading is done by classloader.
Imo this escaping is huge pita, but it boils down to File/URL/URI JDK API being completely broken.
The new NIO FS in JDK7 fixes most of these issues, so we should be fine once we all move over to JDK7+.

I agree with this being a bad fix, and "weird" paths will almost certain have issues.
But using such path / directory, just calls for trouble -- not just for Weld.
If it's only Weld, then I would love to hear how others solve this. ;-)

                
> URIs escaped twice in URLScanner
> --------------------------------
>
>                 Key: WELD-954
>                 URL: https://issues.jboss.org/browse/WELD-954
>             Project: Weld
>          Issue Type: Bug
>          Components: Bootstrap and Metamodel API
>    Affects Versions: 1.1.2.Final
>            Reporter: Emond Papegaaij
>            Assignee: Ales Justin
>
> The fix for WELD-834 can cause spaces to be escaped twice in an URL. This leads to errors like: Error handling file /var/lib/jenkins/jobs/Wicket%2520Weld/workspace/wicket-cdi-examples/target/classes
> Notice how 'Wicket%20Weld' is escaped to 'Wicket%2520Weld'. https://github.com/papegaaij/wicket-cdi demonstrates the problem, clone the project in a directory with a space in the name, and run 'mvn install -Dwicket.version=1.5-RC5.1'.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira