[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken

Marko Lukša (JIRA) jira-events at lists.jboss.org
Thu Mar 1 05:20:48 EST 2012


    [ https://issues.jboss.org/browse/WELD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672517#comment-12672517 ] 

Marko Lukša commented on WELD-999:
----------------------------------

Actually, it's not broken. I have added another test - one that actually invokes an intercepted method and checks if both interceptors were invoked. The test passes.

So the actual problem is only with {{BeanManager.resolveInterceptors(InterceptionType type, Annotation... interceptorBindings)}}. 

In weld-core, the {{interceptorBindings}} parameter is always flattened ({{AbstractClassBean.flattenInterceptorBindings()}}) before being passed to the method. 

In {{InterceptorBindingTransitivityTest}} however, {{resolveInterceptors()}} is called without flattening interceptor bindings first (e.g. {{resolveInterceptors(InterceptionType.AROUND_INVOKE, new UltraSynchronizedLiteral())}}. 


So the real question is whether {{BeanManager.resolveInterceptors()}} should flatten the interceptorBindings itself or whether the caller should to this. 
                
> Interceptor binding transitivity broken
> ---------------------------------------
>
>                 Key: WELD-999
>                 URL: https://issues.jboss.org/browse/WELD-999
>             Project: Weld
>          Issue Type: Bug
>          Components: Interceptors and Decorators
>    Affects Versions: 1.1.2.Final
>            Reporter: Jozef Hartinger
>            Assignee: Marko Lukša
>             Fix For: 1.2.0.Beta1
>
>
> See org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       



More information about the weld-issues mailing list