[wildfly-dev] JConsole plugin - fallback and query for management address
Bartosz Baranowski
bbaranow at redhat.com
Mon Aug 5 04:52:18 EDT 2013
Hey Guys.
I missed last comment on related PR, hence I did not start this thread.
Currently JConsole plugin does something like:
if(as7Remoting){
//use
} else {
//discard connection
// try to connect on hardcoded values locahost:9990
}
https://github.com/wildfly/wildfly/blob/master/cli/src/main/java/org/jboss/as/cli/gui/JConsoleCLIPlugin.java#L100
Ive propesed a change to use existing connection to query for proper IP/port pair of management interface and than attempt to use cmdContext.connect. However it has been deemed as unfit fix - even though it just addapts IP/port rather than make plugin always use localhost:9990.
Darran commented on this at some point:
"However as I have said elsehwere I think this is attempting to fix a 'feature' that should not exist in it's current form"
Trick is that this "feature" is there, its faulty, but if its removed, it breaks backward compatibility.
Also:
Where jconsole is connected to the process locally I suggest two alternatives: -
- Add the CLI tab but with a clear message stating why the CLI is not currently available, potentially add an 'Establish Connection' button to the tab with the capability to prompt for a username and password if required and make use of the discovered address.
-Add an MBean that can handle management ops, the CLI integration can use that MBean regardless of the connection method and would not require the establishment of additional connections.
So, any comments/suggestions?
More information about the wildfly-dev
mailing list