[wildfly-dev] Copies of LazyValidatorFactory

[ssilvert at redhat.com]

On 8/21/2013 3:04 AM, Gunnar Morling wrote:
> Hi Stan,
>
> 2013/8/20 <ssilvert at redhat.com <mailto:ssilvert at redhat.com>>
>
>     On 8/14/2013 3:08 PM, Farah Juma wrote:
>>     Hi,
>>
>>     I recently worked on CDI and Bean Validation integration for method validation (WFLY-529). As described in [1], part of this work involved replacing the delegate of the EE LazyValidatorFactory with a CDI-enabled ValidatorFactory. However, JCA and JPA still currently use copied versions of the old EE LazyValidatorFactory. Since JCA and JPA should also have access to the CDI-enabled ValidatorFactory, it would be good if we could remove the copies (i.e., remove JCAValidatorFactory and JPALazyValidatorFactory) and use the current EE LazyValidatorFactory directly instead. As discussed with Scott Marlow, for JPA, it looks like we can access the EE LazyValidatorFactory from the deployment unit attachment (i.e., via deploymentUnit.getAttachment(BeanValidationAttachments.VALIDATOR_FACTORY)), as described in WFLY-1705 [2]. However, for JCA, it doesn't seem like this will be possible since the code that currently instantiates the JCAValidatorFactory doesn't have access to the deploymen!
>>      tUnit (and it seems like there isn't a way to modify the code to be able to access this). Another option might be to register the ValidatorFactory as a service and then perform a manual lookup on the service.
>>
>>     I was wondering if anyone had any thoughts about what approach to take for JCA or how to go about removing the JCAValidatorFactory. I've created WFLY-1882 [3] to track this. In addition to JCA and JPA, we'll need to consider what should be done for JSF since it will also need to be able to access the CDI-enabled ValidatorFactory. Note that JSF doesn't use a copy of the EE LazyValidatorFactory and so it seems to be bootstrapping Bean Validation in another way.
>     Farah,
>
>     JSF bootstraps Bean Validation as per JSF spec section 3.5.6.2
>     <http://3.5.6.2>:
>
>         /The Bean Validation ValidatorFactory is the main entry point
>         into Bean Validation and is responsible for creating//
>         //Validator instances. [P1-start-validatoryfactory]A
>         ValidatorFactory is retrieved using the following algorithm://
>         //If the servlet context contains a ValidatorFactory instance
>         under the attribute named//
>         //javax.faces.validator.beanValidator.ValidatorFactory, this
>         instance is used by JSF to acquire Validator instances//
>         //(specifically in the BeanValidator). This key should be
>         defined in the constant named VALIDATOR_FACTORY_KEY//
>         //on BeanValidator.//
>         //If the servlet context does not contain such an entry, JSF
>         looks for a Bean Validation provider in the classpath. If//
>         //present, the standard Bean Validation bootstrap strategy is
>         used. If not present, Bean Validation integration is//
>         //disabled.//
>         /
>
>     In our case, we use the second method, which is to simply place
>     the Bean Validation provider in the classpath.  For every
>     deployment that uses JSF, the JSF subsystem will add the
>     org.hibernate.validator module to the deployment.
>
>
> Thanks for that info, that's very helpful. The problem we're trying to
> solve is making sure that Bean Validation and CDI are properly
> integrated as required by the BV spec. For instance CDI-based
> dependency injection must be available to constraint validator
> implementations.
>
> The validator factory maintained in the WildFly EE module (which e.g.
> is available via JNDI) provides this functionality as it is configured
> as necessary during bootstrap. A validator factory obtained via the
> standard BV bootstrap strategy won't offer this functionality, though.
>
> So based on what you say, one solution for the JSF case could be to
> make the VF from the EE module available in the servlet context, e.g.
> by retrieving it via JNDI (assuming the order of loading the modules
> allows for that). I'm not sure though about a WAR deployment which is
> CDI-enabled. Is the EE module activated in this case?
I'm not sure what you mean by "Is the EE module activated?".

It's easy enough for you to try out putting your ValidatorFactory into
the ServletContext.  This class is where bean validation is added to the
deployment and it also has an example of stuffing a value into the
ServletContext at deployment time.
https://github.com/wildfly/wildfly/blob/master/jsf/subsystem/src/main/java/org/jboss/as/jsf/deployment/JSFDependencyProcessor.java
>
>
>
>
>>     [1] https://issues.jboss.org/browse/WFLY-529?focusedCommentId=12787076&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12787076
>>     [2] https://issues.jboss.org/browse/WFLY-1705
>>     [3] https://issues.jboss.org/browse/WFLY-1882
>>
>>     Thanks,
>>     Farah
>>
>>     _______________________________________________
>>     wildfly-dev mailing list
>>     wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>>     https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
>     _______________________________________________
>     wildfly-dev mailing list
>     wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>     https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/wildfly-dev/attachments/20130821/c8ec4b96/attachment.html