[wildfly-dev] Call For Help (Testsuite)

[Jeff Mesnil]

Le 18 juin 2013 à 08:53, Carlo de Wolf <cdewolf at redhat.com> a écrit :

> On 06/14/2013 11:33 AM, Jeff Mesnil wrote:
>> Le 14 juin 2013 à 11:25, Tomaž Cerar <tomaz.cerar at gmail.com> a écrit :
>> 
>>> org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testActiveBackupReload
>>> org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testLiveReload
>> I've sent a PR[1] for these tests. The intermittent failures occur during a :reload operation when the connection is closed before the operation result returns.
>> I swallow up the exception for this special case and this should prevent anymore failure.
>> 
>> Note that these tests would be revisited when we provide a high-level reload operation on the client that takes care of the disconnection/reconnection issues.
>> 
>> jeff
>> 
>> [1] https://github.com/wildfly/wildfly/pull/4639
>> 
> This is a hack to hide the real issue. I don't want anything that hides issues, if possible I want a real fix. If not, then just let it stand out for further analysis.
> I propose we rollback https://github.com/wildfly/wildfly/pull/4639.

Afaict, the tests are executing a :reload are swallowing up the exception is the channel is closed prematurely[1][2].

If we want to remove this, the :reload command must refactored to make sure it returns before the channel of the server is closed.

Note that in the HornetQBackupActivationTestCase, the :reload operation would normally be executed by an admin using the cli and would not be intermingled with application code. That's not the important part of the test: it checks that HornetQ master/slaver servers are correctly configured upon server reloading.
We could rollback the test (and keep having intermittent failures) or @Ignore the test but I'd prefer to keep it with the exception swallowing rather than having a regression on this test undetected until we get customer issue.

jeff

[1] https://github.com/wildfly/wildfly/blob/master/testsuite/domain/src/test/java/org/jboss/as/test/integration/respawn/RespawnTestCase.java#L384
[2] https://github.com/wildfly/wildfly/blob/master/testsuite/shared/src/main/java/org/jboss/as/test/integration/domain/management/util/DomainLifecycleUtil.java#L335

-- 
Jeff Mesnil
JBoss, a division of Red Hat
http://jmesnil.net/