[wildfly-dev] package name change a good idea?
Scott Marlow
smarlow at redhat.com
Thu May 2 11:59:54 EDT 2013
On 05/02/2013 11:31 AM, Brian Stansberry wrote:
> On 5/2/13 7:59 AM, Bill Burke wrote:
>> But doesn't it make it much harder for EAP 6.0 -> Wildfly upstream?
>>
>
> I guess you're mostly concerned about this statement?
>
> >>> Old packages could be renamed only when the got some big
> >>> upgrade/change that would break compatibility anyway.
>
> I vote that we do that very, very rarely, and with lots of discussion
> first. Just my 2 cents, but I don't see any renaming happening for a
> looonnng time for externally consumable API.
I've been moving some JPA related code (SPI/API) to org.jipijapa but
will keep deprecated org.jboss.as.jpa classes around that extend the new
ones.
This won't impact the JPA (EE) container code, which still be in WildFly
8 (via the current org.jboss.as.jpa package.)
Is there any reason to use org.wildfly at all? Or could we keep
org.jboss.* as long as possible?
>
> As for EAP 6.0 -> WildFly, AFAICT where that would matter is some new
> feature being developed for EAP. And that feature is going to have to go
> into WildFly at the same time. So if we decide to call the relevant
> package org.wildfly there's no issue.
>
> I doubt that using org.wildfly for all new packages makes sense (or is
> even being proposed.) Within a given module I'd rather see a coherent
> set of packages than a semi-random split based on when a package came
> in. So if some new functionality comes into a module with a coherent set
> of org.wildfly packages, fine. But if it sprinkles random org.wildfly
> stuff around instead of putting pieces in the logical spots in the
> existing org.jboss.as tree, that's wrong.
>
>
>> Also, what about jboss-logging et. al.? Will they be renamed and
>> packages changed? If so, this creates a headache for projects that
>> depend on those libraries. For example, I'd want future resteasy
>> releases to work with both AS 7.1 and Wildfly. I'd have to write an
>> abstraction layer for any old jboss utility library I reference so my
>> code would work between as7 and wildfly.
>>
>> On 5/2/2013 8:17 AM, Brian Stansberry wrote:
>>> No. WildFly will be the upstream for a future release of EAP. When that
>>> happens, those classes, in the existing org.wildfly packages, will be
>>> used in EAP.
>>>
>>> This is conceptually no different than cases where packages like
>>> org.apache appear in EAP. EAP is a product that is built from a variety
>>> of upstream projects. WildFly is one of those upstream projects. This
>>> was the case before the rename as well; the project fka JBoss AS was
>>> just one of the upstream projects in EAP.
>>>
>>> On 5/2/13 7:10 AM, Jaromir Hamala wrote:
>>>> Hi,
>>>>
>>>> does it mean the same classes will be under different packages in EAP
>>>> and WildFly? Wouldn't this make a transition from WildFly to EAP harder?
>>>>
>>>> Cheers,
>>>> Jaromir
>>>>
>>>>
>>>> On Thu, May 2, 2013 at 12:53 PM, Tomaž Cerar <tomaz.cerar at gmail.com
>>>> <mailto:tomaz.cerar at gmail.com>> wrote:
>>>>
>>>> We never said we are going to be renaming existing packages.
>>>> Especially because we don't want to break compatibly or make back
>>>> porting harder.
>>>>
>>>> What we did agree on is that new stuff should be in new package names.
>>>> Old packages could be renamed only when the got some big
>>>> upgrade/change that would break compatibility anyway.
>>>>
>>>> --
>>>> tomaz
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Thu, May 2, 2013 at 12:48 PM, Bill Burke <bburke at redhat.com
>>>> <mailto:bburke at redhat.com>> wrote:
>>>>
>>>> Are you sure a package name change is a good idea? Won't it make it
>>>> harder to pull/push changes upstream and downstream? And create
>>>> additional work for those who already are the bottleneck in the
>>>> release
>>>> process? What does Fedora/RHEL do?
>>>> --
>>>> Bill Burke
>>>> JBoss, a division of Red Hat
>>>> http://bill.burkecentral.com
>>>> _______________________________________________
>>>> wildfly-dev mailing list
>>>> wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> wildfly-dev mailing list
>>>> wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> “Perfection is achieved, not when there is nothing more to add, but when
>>>> there is nothing left to take away.”
>>>> Antoine de Saint Exupéry
>>>>
>>>>
>>>> _______________________________________________
>>>> wildfly-dev mailing list
>>>> wildfly-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>>>
>>>
>>>
>>
>
>
More information about the wildfly-dev
mailing list