[wildfly-dev] Batch Subsystem Model
Brian Stansberry
brian.stansberry at redhat.com
Fri Sep 13 11:28:18 EDT 2013
On 9/13/13 10:17 AM, James R. Perkins wrote:
> Thanks for all the feedback. If I'm understanding everything right we'll
> end with something like the following for in-memory.
>
> <subsystem xmlns="urn:jboss:domain:batch:1.0">
> <job-repository>
> <in-memory thread-pool="default"/>
> </job-repository>
> <thread-pool name="default">
> <max-threads count="10"/>
> <keepalive-time time="100" unit="milliseconds"/>
> </thread-pool>
> </subsystem>
>
> "subsystem" => {
> "batch" => {
> "job-repository" => { "in-memory" => {
> "thread-pool" => "default"
> }},
> "thread-pool" => { "default" => {
> "max-threads" => "10",
> "keepalive-time" => "100",
> "keepalive-unit" => "milliseconds"
> }}
> }
> }
>
> And something like the following for JDBC.
>
> <subsystem xmlns="urn:jboss:domain:batch:1.0">
> <job-repository>
> <jdbc thread-pool="default"
> jndi-name="java:jboss/datasources/ExampleDS"/>
> </job-repository>
> <thread-pool name="default">
> <max-threads count="10"/>
> <keepalive-time time="100" unit="milliseconds"/>
> </thread-pool>
> </subsystem>
>
> "subsystem" => {
> "batch" => {
> "job-repository" => { "jdbc" => {
> "thread-pool" => "default",
> "jndi-name" => "java:jboss/datasources/ExampleDS"
> }},
> "thread-pool" => { "default" => {
> "max-threads" => "10",
> "keepalive-time" => "100",
> "keepalive-unit" => "milliseconds"
> }}
> }
> }
>
> I personally prefer the <job-repository><in-memory/></job-repository>
> over the <in-memory-job-repository/>, but I don't care all that much. If
> the consensus is the later, that's fine.
>
I didn't fully absorb all the details on this thread, so if someone had
a reason for <in-memory-job-repository/>, ignore this and get a
consensus with them. Otherwise
<job-repository><in-memory/></job-repository> seems fine.
> Also do we want the thread pool to be called batch-thread-pool or just
> simply thread-pool?
>
I don't see how batch-thread-pool is much more informative than just
'thread-pool'. If you don't understand what the thread pool is for,
adding 'batch-' at the front doesn't really tell you. Either way you'd
need to read docs, xsd or the description text in the management API
metadata.
> Thanks for all the feedback. I just wanted to get it right since what we
> decide we're stuck with.
>
--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
More information about the wildfly-dev
mailing list