[wildfly-dev] Change WebServices subsystem to use PersistentResourceXMLDescription

Brian Stansberry brian.stansberry at redhat.com
Tue Dec 9 09:26:57 EST 2014


On 12/9/14, 7:10 AM, Claudio Miranda wrote:
> There are two proposed changes:
> 1. change subsystem implementation to use PersistentResourceXMLDescription
> 2. modify subsystem xml, the wsdl elements to attributes.
>
> On Tue, Dec 9, 2014 at 9:07 AM, Alessio Soldano <asoldano at redhat.com> wrote:
>> Frankly, I don't see any immediate benefit from these changes (perhaps the model would look a bit
>> clearer to the final user?), while it looks like we might get some in the future.
>
> It brings no immediate benefit for users. I saw other subsystem
> implementation (mail, undertow) uses PersistentResourceXMLDescription
> and attributes, so I thought it would be a good idea to (kind of)
> "modernize" webservices subsystem.
>
> This is much more a personal exercise for me to better understand
> subsystem implementation, if it doesn't fail the tests, would be good
> to PR it.
>

My only other comment on this is the xml style should be consistent 
across the entire subsystem, so if this is only for a part (I'm too lazy 
to look) then that's not good.

But I support the idea of moving to this style in general. Attributes 
instead of text elements is much more 'standard' for the WildFly config 
files. And I expect things will keep moving that way, so stuff that 
doesn't will seem more and more "non-standard".

-- 
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat


More information about the wildfly-dev mailing list