[wildfly-dev] the WildFly 9 org.jboss.metadata.common module is missing javax.persistence...

[Scott Marlow]

The build succeeds if we specify 'optional="true"' 
(https://github.com/wildfly/wildfly-build-tools/blob/master/feature-pack-build-maven-plugin/src/main/java/org/wildfly/build/featurepack/FeaturePackBuilder.java 
does not do the same verification for optional dependencies).


On 12/15/2014 07:15 PM, Scott Marlow wrote:
> I tried adding javax.persistence.api to org.jboss.metadata.common [3]
> but get the following build error [4].
>
> ERROR] Failed to execute goal
> org.wildfly.build:wildfly-feature-pack-build-maven-plugin:1.0.0.Alpha6:build
> (feature-pack-build) on project wildfly-web-feature-pack: Execution
> feature-pack-build of goal
> org.wildfly.build:wildfly-feature-pack-build-maven-plugin:1.0.0.Alpha6:build
> failed: java.lang.RuntimeException: Some errors were encountered
> creating the feature pack
> [ERROR] Missing module ModuleIdentifier{name='javax.persistence.api',
> slot='main'}. Module was required by
> [ModuleIdentifier{name='org.jboss.metadata.common', slot='main'}]
> [ERROR]
>
> Is there another file besides
> web-feature-pack/src/main/resources/modules/system/layers/base/org/jboss/metadata/common/main/module.xml
> that also needs the dependency?
>
> Scott
>
> [3]
> https://github.com/scottmarlow/wildfly/tree/jbossmetadata_javaxpersistence
>
> [4] https://gist.github.com/scottmarlow/7d04490677e93a7de35f
>
> On 12/15/2014 04:29 PM, Stuart Douglas wrote:
>> Yes
>>
>> Stuart
>>
>> Scott Marlow wrote:
>>> On 12/15/2014 03:46 PM, Stuart Douglas wrote:
>>>> By adding the imports?
>>>
>>> The current location for the module definition appears to be
>>> web-feature-pack/src/main/resources/modules/system/layers/base/org/jboss/metadata/common/main/module.xml,
>>>
>>> is that the right location for org.jboss.metadata.common?
>>>
>>>
>>>>
>>>> Stuart
>>>>
>>>> Scott Marlow wrote:
>>>>> Some of the WildFly 9 TCK tests are failing because
>>>>> javax.persistence.api is missing from the org.jboss.metadata.common
>>>>> module. In WildFly 8.2, we had [1] org.jboss.metadata which had various
>>>>> javax APIs. In WildFly 9, org.jboss.metadata.ejb has the different
>>>>> javax APIs but org.jboss.metadata.common [2] does not.
>>>>>
>>>>> How should this be fixed?
>>>>>
>>>>> Scott
>>>>>
>>>>> [1]
>>>>> https://github.com/wildfly/wildfly/blob/8.x/build/src/main/resources/modules/system/layers/base/org/jboss/metadata/main/module.xml
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> <module xmlns="urn:jboss:module:1.3" name="org.jboss.metadata">
>>>>> <properties>
>>>>> <property name="jboss.api" value="private"/>
>>>>> </properties>
>>>>>
>>>>> <resources>
>>>>> <!-- Insert resources here -->
>>>>> </resources>
>>>>>
>>>>> <dependencies>
>>>>> <module name="javax.annotation.api"/>
>>>>> <module name="javax.api"/>
>>>>> <module name="javax.ejb.api" optional="true"/>
>>>>> <module name="javax.interceptor.api" optional="true"/>
>>>>> <module name="javax.jws.api" optional="true"/>
>>>>> <module name="javax.persistence.api" optional="true"/>
>>>>> <module name="javax.servlet.api" optional="true"/>
>>>>> <module name="javax.servlet.jsp.api" optional="true"/>
>>>>> <module name="javax.xml.bind.api" optional="true"/>
>>>>> <module name="javax.xml.ws.api" optional="true"/>
>>>>> <module name="org.jboss.ejb3" optional="true"/>
>>>>> <module name="org.jboss.staxmapper"/>
>>>>> <module name="org.jboss.logging"/>
>>>>> </dependencies>
>>>>> </module>
>>>>>
>>>>> [2]
>>>>> dist/target/wildfly-9.0.0.Alpha2-SNAPSHOT/modules/system/layers/base/org/jboss/metadata/common/main/module.xml
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> <module xmlns="urn:jboss:module:1.3" name="org.jboss.metadata.common">
>>>>> <properties>
>>>>> <property name="jboss.api" value="private"/>
>>>>> </properties>
>>>>>
>>>>> <resources>
>>>>> <resource-root path="jboss-metadata-common-8.1.2.Final.jar"/>
>>>>> </resources>
>>>>>
>>>>> <dependencies>
>>>>> <module name="javax.annotation.api"/>
>>>>> <module name="javax.api"/>
>>>>> <module name="org.jboss.staxmapper"/>
>>>>> <module name="org.jboss.logging"/>
>>>>> </dependencies>
>>>>> </module>
>>>>> _______________________________________________
>>>>> wildfly-dev mailing list
>>>>> wildfly-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>