[wildfly-dev] Metrics & runtime attribute registration

[Tomaž Cerar]

Hey guys,

We had interesting discussion with Brian on
https://github.com/wildfly/wildfly-core/pull/848#issuecomment-119778986
about how we register runtime/metric attribute on resources.

There are many cases where subsystems only register attributes / resources
only when server is booting into normal mode.
but if it server is booted only to "admin mode" all that runtime/metrics
attributes are not registered and as such not seen in the model.

Registering runtime attributes only in normal mode can cause that results
of :read-resource-description/read-resource
wouldn't return attributes that are on resources if server is started in
admin mode or even CLI standalone.
Our metadata already provides information if attributes is
runtime/metric/configuration.

This can cause problems for tooling that relies on output of those two
operations.

Looking at current state of the code, we do use both ways of registering
attributes either conditionally or always.
This probably originates from times where there was no good api/way to mark
attribute/resource as runtime.

I am personally am in favor of always registering runtime attributes as
this makes sure that user isn't surprised by some extra/missing
attributes based on fact how it is starting the server.


What do you guys think? Should we always register it or have it
conditionally?

--
tomaz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/wildfly-dev/attachments/20150713/f0a0c9c3/attachment.html