[wildfly-dev] Embedded Arquillian Container
Brian Stansberry
brian.stansberry at redhat.com
Wed May 6 12:10:43 EDT 2015
On 5/6/15 2:06 AM, Lukas Fryc wrote:
> The embedded container works great with your PR!
>
> Personally I'd say: ship it! :-)
>
> Can someone review and merge?
>
I'll need to get https://issues.jboss.org/browse/WFCORE-677 into WildFly
Core 1.0.0.CR2. And once that's there, Tomaz (or someone), please add a
commit getting rid of the "bundlePath" property from
https://github.com/wildfly/wildfly-arquillian/blob/master/container-embedded/src/main/java/org/jboss/as/arquillian/container/embedded/EmbeddedContainerConfiguration.java
Thanks.
> On Mon, May 4, 2015 at 2:34 PM, Tomaž Cerar <tomaz.cerar at gmail.com
> <mailto:tomaz.cerar at gmail.com>> wrote:
>
> Guys,
>
> I've sent PR https://github.com/wildfly/wildfly-arquillian/pull/18
> that adds back embedded arquillian container
> which uses wildfly-core embedded api.
>
> --
> tomaz
>
> On Mon, May 4, 2015 at 1:35 PM, Cody Lerum <cody.lerum at gmail.com
> <mailto:cody.lerum at gmail.com>> wrote:
>
> Is there a good example published somewhere for users who want
> to use a managed container within a CI like Travis?
>
> This is becoming an increasingly pretty popular configuration,
> and the easier for the users to get started and update from
> release to release the better.
>
> -C
>
> On May 4, 2015 3:28 AM, "Lukas Fryc" <lfryc at redhat.com
> <mailto:lfryc at redhat.com>> wrote:
>
> An only embedded container's advantage over managed
> container is a simpler test debugging - no special setup
> required.
>
> I'm fine with dropping it, just in case it wasn't
> intentional decision to remove embedded container, we can
> re-introduce it.
>
> ~ Lukas
>
> On Thu, Apr 30, 2015 at 3:47 PM, Brian Stansberry
> <brian.stansberry at redhat.com
> <mailto:brian.stansberry at redhat.com>> wrote:
>
> Hi Lukas,
>
> On 4/29/15 9:58 AM, Lukas Fryc wrote:
> > Hey guys,
> >
> > just wondering if wildfly-arquillian-container-embedded was discontinued
> > with split of 9.x:
> >
> >https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
> >
>
> It was, yes, as wildfly-arquillian shouldn't depend on
> WildFly Full (to
> avoid a circular dependency) and WildFly Core didn't
> have an embedding
> module.
> >
> > When working on a re-enablement, I found out that even though arq
> > adapter now depends on wildfly-core/embedded, particularly
> > on EmbeddedServerFactory, this class has its counterpart in
> > wildfly/embedded as well.
> >
>
> I added the wildfly-core/embedded module in order to
> support the Offline
> CLI.[1] At this point I consider it to be an internal
> module, not
> public API. I expect that will soften over time, but for
> WildFly Core
> 1.0 / WildFly Full 9.0 at least, that's what it is.
>
> [1] http://wildfly.org/news/2015/03/13/Offline-CLI/
>
> > Question is, should be embedded arquillian container still available for
> > 9.x?
> >
>
> Jason Greene would need to rule on that, but I know we
> were ok with
> dropping it before. Is there much use of it?
>
> > If yes, I can continue and provide a PR, just I will need a bit of
> > guidance with what EmbeddedServerFactory it should actually use (if that
> > matters).
> >
>
> What API would it need from wildfly-core/embedded? Is the
> StandaloneServer API there adequate?
>
> >
> > Cheers,
> >
> > ~ Lukas
> >
> > --
> > Lukas Fryc
> > AeroGear Core Developer
> > Red Hat
> >
> >
> > _______________________________________________
> > wildfly-dev mailing list
> > wildfly-dev at lists.jboss.org
> <mailto:wildfly-dev at lists.jboss.org>
> > https://lists.jboss.org/mailman/listinfo/wildfly-dev
> >
>
>
> --
> Brian Stansberry
> Senior Principal Software Engineer
> JBoss by Red Hat
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org
> <mailto:wildfly-dev at lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
>
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
--
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat
More information about the wildfly-dev
mailing list